Remove InvocationContext #2108
Merged
Remove InvocationContext #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…<string> as it allows for less
it allows us for creating the host and everything else after parsing has finished UseCommandHandler must specify the handler for instance of a Command, not per type as there can be multiple commands of the same type
# Conflicts: # src/System.CommandLine.ApiCompatibility.Tests/ApiCompatibilityApprovalTests.System_CommandLine_api_is_not_changed.approved.txt # src/System.CommandLine.Tests/Invocation/InvocationPipelineTests.cs # src/System.CommandLine/Builder/CommandLineBuilder.cs # src/System.CommandLine/Builder/CommandLineBuilderExtensions.cs # src/System.CommandLine/CommandLineConfiguration.cs
|
@jonsequitur the PR is ready. If you approve it and want to merge it, please squash it and remove the commit message (it consists of many commits that were already merged) |
jonsequitur
reviewed
Mar 28, 2023
| @@ -382,13 +381,13 @@ internal sealed class OptionAction : CliAction | |||
| { | |||
| internal bool WasCalled = false; | |||
|
|
|||
| public override int Invoke(InvocationContext context) | |||
| public override int Invoke(ParseResult context) | |||
There was a problem hiding this comment.
Suggested change
| public override int Invoke(ParseResult context) | |
| public override int Invoke(ParseResult parseResult) |
jonsequitur
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.