UnrecognizedArgument error should mention first invalid argument, not the last one #2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Jan 20, 2023
jonsequitur
approved these changes
Jan 20, 2023
adamsitnik
commented
Jan 20, 2023
Co-authored-by: Jon Sequeira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1959 I've introduce a bug that SDK has hit in dotnet/sdk#29131
Previously, the method was returning error for the first mismatch:
command-line-api/src/System.CommandLine/Parsing/SymbolResult.cs
Lines 132 to 135 in 82273cb
After my changes it was the last one. This fix just helps me to unblock the SDK update, it does not solve the problem of producing multiple errors by a single validator.