Skip to content

Move Kestrel shared source to src\Shared #46112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 23, 2023
Merged

Move Kestrel shared source to src\Shared #46112

merged 6 commits into from
Jan 23, 2023

Conversation

@david-acker
Copy link
Member

@david-acker david-acker commented Jan 15, 2023 •
edited
Loading

Move Kestrel shared source to src\Shared

  • Moves the following Kestrel shared source to src\Shared:
    • HttpSysHttp3SupportedAttribute.cs
    • MsQuicSupportedAttribute.cs
    • TestResources.cs
    • \TestCertificates

Fixes #36035

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 15, 2023
@ghost
Copy link

ghost commented Jan 15, 2023

Thanks for your PR, @david-acker. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@david-acker david-acker changed the title Move Kestrel shared source test attributes to src\Shared Move Kestrel shared source to src\Shared Jan 19, 2023
@Tratcher
Copy link
Member

Tratcher commented Jan 19, 2023

CSC : error CS2001: Source file '/Users/runner/work/1/s/src/Servers/Kestrel/shared/test/TestResources.cs' could not be found. [/Users/runner/work/1/s/src/Servers/Kestrel/Transport.NamedPipes/test/Microsoft.AspNetCore.Server.Kestrel.Transport.NamedPipes.Tests.csproj]
##[error]CSC(0,0): error CS2001: (NETCORE_ENGINEERING_TELEMETRY=Build) Source file '/Users/runner/work/1/s/src/Servers/Kestrel/shared/test/TestResources.cs' could not be found.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=141848&view=logs&j=48c285a2-daf4-5ecb-cb99-42232769ca29&t=1c30c545-4674-57a0-c50f-14816b5373e6&l=1125

@Tratcher
Copy link
Member

Tratcher commented Jan 19, 2023 •
edited
Loading

src/Shared/TestCertificates/make-test-certs.sh 100755 → 100644? This might need to be chmod'd

@david-acker
Copy link
Member Author

david-acker commented Jan 19, 2023

Interesting, good catch. I've added back execute permissions for that script.

@Tratcher
Copy link
Member

Tratcher commented Jan 19, 2023

Thanks

@Tratcher Tratcher self-assigned this Jan 19, 2023
@Tratcher Tratcher added this to the 8.0-preview1 milestone Jan 19, 2023
@build-analysis build-analysis bot mentioned this pull request Jan 20, 2023
Open
5 tasks
@Tratcher
Copy link
Member

Tratcher commented Jan 23, 2023

/azp run

@Tratcher Tratcher enabled auto-merge (squash) January 23, 2023 16:49
@azure-pipelines
Copy link

azure-pipelines bot commented Jan 23, 2023

Azure Pipelines successfully started running 3 pipeline(s).

@Tratcher Tratcher merged commit 3261139 into dotnet:main Jan 23, 2023
atossell91 pushed a commit to atossell91/aspnetcore that referenced this pull request Jan 23, 2023
@david-acker @atossell91
Move Kestrel shared source to src\Shared (dotnet#46112)
f85177d
@wtgodbe wtgodbe mentioned this pull request Jan 24, 2023
Merged
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
@david-acker david-acker deleted the move-kestrel-shared-test-attributes branch February 10, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell

Assignees

@Tratcher Tratcher

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

8.0-preview1

Development

Successfully merging this pull request may close these issues.

Consider moving Kestrel shared source test attributes to src\Shared

4 participants

@david-acker @Tratcher @amcasey @mkArtakMSFT