Skip to content

Conversation

@Tratcher
Copy link
Member

@Tratcher Tratcher commented Sep 10, 2019

Cherry pick of #13858 but expanded to account for the 3.0 defaults change from Lax to None. This preserves the old behavior of None for most components using a default value by witching them to -1 (Unspecified). E.g. new CookieOptions() excludes samesite like before unless you explicitly set it.

@Tratcher Tratcher requested a review from HaoK September 10, 2019 20:38
@Tratcher Tratcher self-assigned this Sep 10, 2019
@HaoK
Copy link
Member

HaoK commented Sep 10, 2019

Yeah definitely should go with a less specific namespace if we are using it in 3 places now Microsoft.AspNetCore.SuppressSameSiteNone seems fine

@analogrelay analogrelay added the Servicing-consider Shiproom approval is required for the issue label Sep 17, 2019
@analogrelay analogrelay added this to the 3.0.x milestone Sep 17, 2019
@analogrelay analogrelay removed the Servicing-consider Shiproom approval is required for the issue label Sep 17, 2019
@Tratcher Tratcher added the Servicing-consider Shiproom approval is required for the issue label Sep 30, 2019
@Tratcher Tratcher force-pushed the tratcher/3.0/samesite branch from 973708d to e243b2b Compare October 2, 2019 23:20
@Tratcher
Copy link
Member Author

Tratcher commented Oct 3, 2019

This branch has been updated to be in sync with the others.

Outstanding items:

  • Confirm if there is or is not going to be a October patch, and when the branch really opens for November.
  • PatchConfig.props.
    • Microsoft.Net.Http.Headers
    • Microsoft.AspNetCore.Http.Abstractions
    • Microsoft.AspNetCore.Http.Features
    • Microsoft.AspNetCore.CookiePolicy

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/3156
https://github.com/aspnet/AspNetCore-Internal/issues/2617

@vivmishra vivmishra modified the milestones: 3.0.x, 3.0.2 Oct 4, 2019
@vivmishra vivmishra added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Oct 4, 2019
@Tratcher Tratcher force-pushed the tratcher/3.0/samesite branch from e243b2b to cd258cf Compare October 8, 2019 21:57
@Tratcher Tratcher marked this pull request as ready for review October 9, 2019 18:48
@Tratcher Tratcher requested review from a team, analogrelay and jkotalik as code owners October 9, 2019 18:48
@Tratcher Tratcher modified the milestones: 3.0.2, 3.0.1 Oct 9, 2019
@analogrelay analogrelay merged commit c0a7f04 into release/3.0 Oct 9, 2019
@analogrelay analogrelay deleted the tratcher/3.0/samesite branch October 9, 2019 21:19
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants