Minor dashboard improvements and clean up #9301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces minor dashboard improvements and cleanup across multiple areas including localization updates, telemetry/logging enhancements, and code refactoring for subscription management and HTTP client creation.
- Updated XLF resource files to remove extraneous click instructions and add new tooltips for resource states.
- Refactored TelemetryRepository and Subscription to simplify processing and manage callback execution via a throttler.
- Changed log entry internal identifier generation from a Guid to an Interlocked-incremented long and improved related utility functions.
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Dashboard/Resources/xlf/Columns.*.xlf | Updated translation sources, targets, and added new trans-units for resource waiting/not started states. |
| src/Aspire.Dashboard/Resources/Columns.resx | Removed click instructions from tooltips and added new values for resource state messages. |
| src/Aspire.Dashboard/Otlp/Storage/TelemetryRepository.cs | Refactored log trace lookup logic by replacing try-catch with a simple loop over traces. |
| src/Aspire.Dashboard/Otlp/Storage/Subscription.cs | Removed internal locking/queueing and replaced it with a CallbackThrottler to manage execution. |
| src/Aspire.Dashboard/Otlp/Model/OtlpLogEntry.cs | Changed InternalId from a Guid to a long using an atomic counter. |
| src/Aspire.Dashboard/Otlp/Model/OtlpHelpers.cs | Defined a constant for shortened IDs and updated matching logic accordingly. |
| src/Aspire.Dashboard/Model/ResourceViewModel.cs | Simplified resource name lookup and iteration over all resources. |
| src/Aspire.Dashboard/Model/ResourceStateViewModel.cs | Updated resource state tooltip logic to include waiting and not started scenarios. |
| src/Aspire.Dashboard/Model/DebugSessionHelpers.cs | Adjusted HTTP client creation to better handle null parameters and update header settings. |
| src/Aspire.Dashboard/Extensions/ResourceViewModelExtensions.cs | Introduced a new IsWaiting() extension method for resource state. |
| src/Aspire.Dashboard/DashboardEndpointsBuilder.cs | Changed culture lookup to use ordered cultures for consistent language selection. |
| src/Aspire.Dashboard/Components/ResourcesGridColumns/LogMessageColumnDisplay.razor.cs | Replaced inline exception text resolution with a shared helper call. |
| src/Aspire.Dashboard/Components/Dialogs/SettingsDialog.razor.cs | Simplified language options assignment and culture matching logic. |
Files not reviewed (1)
- src/Aspire.Dashboard/Resources/Columns.Designer.cs: Language not supported
Comments suppressed due to low confidence (1)
src/Aspire.Dashboard/Otlp/Model/OtlpLogEntry.cs:30
- Switching the InternalId from a Guid to a long via Interlocked.Increment changes the uniqueness guarantees; please confirm that this change meets the system's requirements for unique identifiers.
InternalId = Interlocked.Increment(ref s_nextLogEntryId);
davidfowl
reviewed
May 14, 2025
| public void Dispose() | ||
| { | ||
| _cts.Cancel(); | ||
| _cts.Dispose(); |
davidfowl
reviewed
May 14, 2025
| public OtlpLogEntry(LogRecord record, OtlpApplicationView logApp, OtlpScope scope, OtlpContext context) | ||
| { | ||
| InternalId = Guid.NewGuid(); | ||
| InternalId = Interlocked.Increment(ref s_nextLogEntryId); |
davidfowl
approved these changes
May 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor improvements and clean up
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate