Skip to content

Conversation

@adamint
Copy link
Member

@adamint adamint commented May 9, 2025

Description

Paused:
image

Not paused:
image

Fixes #8457

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@adamint adamint requested a review from JamesNK May 9, 2025 17:55
? string.Format(
CultureInfo.CurrentCulture,
Loc[nameof(Dashboard.Resources.StructuredLogs.PauseInProgressText)],
Loc[nameof(Dashboard.Resources.Traces.PauseInProgressText)],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you check for any other similar mistakes

@danmoseley
Copy link
Member

@JamesNK should revivew so this might miss the cutoff.

@JamesNK
Copy link
Member

JamesNK commented May 10, 2025

I made a couple of changes:

  1. Moved pause warning under graph. That's more consistent with structured logs and tracing which show it at the bottom of the page
  2. Renamed resource value

@JamesNK JamesNK enabled auto-merge (squash) May 10, 2025 01:31
@JamesNK JamesNK merged commit 34b7c0e into dotnet:main May 10, 2025
169 of 170 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WebToolsE2E][Aspire] There isn't a notification message display when you clicked the 'Pause button' in the Metrics Page.

3 participants