Skip to content

Conversation

@mitchdenny
Copy link
Member

Fixes: #9049

Uses enumeration options to skip over inaccessible directories. This solution is still not perfect though because launch aspire run from a directory that has a lot of files results in the GetFiles(...) call taking a long time to run.

We would only make this worse if we manually tried to traverse the directory tree (although we could give feedback on what is going on).

One option I was considering is whether we timeout the search if necessary and tell people to use the --project option if we can't complete the search.

@mitchdenny mitchdenny linked an issue May 8, 2025 that may be closed by this pull request
1 task
@mitchdenny mitchdenny self-assigned this May 8, 2025
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 8, 2025
@mitchdenny mitchdenny requested a review from davidfowl May 8, 2025 01:21
@mitchdenny mitchdenny added area-cli and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 8, 2025
@mitchdenny mitchdenny added this to the 9.3 milestone May 8, 2025
@davidfowl davidfowl merged commit 88ff939 into main May 8, 2025
168 of 170 checks passed
@davidfowl davidfowl deleted the mitchdenny/app-data-fix branch May 8, 2025 04:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error running CLI from user profile

3 participants