Skip to content

Add properties to DockerComposeEnvironmentResource #8882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2025
Merged

Add properties to DockerComposeEnvironmentResource #8882

merged 3 commits into from
Apr 19, 2025

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Apr 19, 2025 •
edited
Loading

Description

  • Introduced DefaultContainerRegistry and DefaultNetworkName properties in DockerComposeEnvironmentResource.
  • Added WithProperties and ConfigureComposeFile extension methods for configuring DockerComposeEnvironmentResource.
  • Updated DockerComposePublishingContext to utilize DefaultNetworkName.
  • Modified tests to validate new properties and ensure correct Docker Compose output.

Fixes #8845

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • No

@davidfowl
Add properties to DockerComposeEnvironmentResource and update related…
f809e93 
… tests

- Introduced DefaultContainerRegistry and DefaultNetworkName properties in DockerComposeEnvironmentResource.
- Added WithProperties extension method for configuring DockerComposeEnvironmentResource.
- Updated DockerComposePublishingContext to utilize DefaultNetworkName.
- Modified tests to validate new properties and ensure correct Docker Compose output.
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 19, 2025
eerhardt
eerhardt approved these changes Apr 19, 2025
View reviewed changes
@eerhardt eerhardt enabled auto-merge (squash) April 19, 2025 12:31
@eerhardt eerhardt merged commit 62c6cf0 into main Apr 19, 2025
175 checks passed
@eerhardt eerhardt deleted the davidfowl/docker-compose-props branch April 19, 2025 12:47
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardt eerhardt eerhardt approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees

No one assigned

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose docker compose file to mutate

3 participants

@davidfowl @eerhardt