Model Docker Compose as compute environment #8828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
force-pushed
the
safia/docker-compose-environment-resource
branch
from
9e612ec to
79498f3
Compare
captainsafia
commented
Apr 16, 2025
| /// </code> | ||
| /// </example> | ||
| public static IResourceBuilder<T> PublishAsDockerComposeService<T>(this IResourceBuilder<T> builder, Action<DockerComposeServiceResource, Service> configure) | ||
| where T : IResource |
There was a problem hiding this comment.
This should use IComputeResource from #8820.
eerhardt
reviewed
Apr 16, 2025
| /// Initializes a new instance of the <see cref="DockerComposeEnvironmentResource"/> class. | ||
| /// </remarks> | ||
| /// <param name="name">The name of the Docker Compose environment.</param> | ||
| public class DockerComposeEnvironmentResource(string name) : Resource(name) |
There was a problem hiding this comment.
Suggested change
| public class DockerComposeEnvironmentResource(string name) : Resource(name) | |
| public class DockerComposeEnvironmentResource(string name) : Resource(name), IComputeEnvironmentResource |
When #8820 is merged.
davidfowl
approved these changes
Apr 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #8786.