[release/9.1] Support Existing Azure AppInsights, OpenAI, and CosmosDB #7690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These resources don't support existing resources yet. Adding support to finish all the Azure resources for existing. Note that for CosmosDB, we only explicitly set DisableLocalAuth if WithAccessKeyAuthentication is called. We don't want to disable local auth on an existing resource if it is already enabled as that might break other uses of the resource. Fix #7665
…d Redis Existing Azure resources can't be directly updated in bicep. When trying to deploy these changes it raises an error "Error BCP173: The property "properties" cannot be used in an existing resource declaration. [https://aka.ms/bicep/core-diagnostics#BCP173]"
…e added to the infrastructure in the opposite order now.
danmoseley
added
the
area-integrations
captainsafia
approved these changes
Feb 19, 2025
danmoseley
approved these changes
Feb 19, 2025
eerhardt
approved these changes
Feb 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7677 to release/9.1
/cc @eerhardt
Customer Impact
Customers are unable to use Azure AppInsights, OpenAI, and CosmosDB existing resources. It will always try provisioning new resources even when calling "AsExisting". For Azure Redis, using AsExisting doesn't work because the bicep fails to deploy since we are setting properties on an existing resource. See https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-core-diagnostics#BCP173
Testing
New bicep tests for these scenarios added.
Risk
Low. Since we are changing the bicep generation code to support existing resources, we may affect the bicep generation of new resources. But existing bicep baseline tests are passing. The only test that required a change was for AppInsights, but that is a simple resource reordering in bicep, which shouldn't affect it.
Regression?
No