Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 24, 2024

Backport of #6425 to release/9.0

/cc @mitchdenny

Customer Impact

Currently when a developer makes Redis Insight persistent using the following code:

var builder = DistributedApplication.CreateBuilder(args);
var redis = builder.AddRedis("redis").WithRedisInsight(c =>
{
  c.WithLifetime(ContainerLifetime.Persistent);
});

On subsequent runs RedisInsight will show additional instances of Redis (one for each launch of the apphost). This is because the import mechanism we use doesn't overwrite existing instances with the same name. This PR changes this logic so that we first pull the list of instances from RedisInsight and create the list of ones we want to delete, and then adds them back in via import).

The reason we delete is that the Redis instance may actually have changed credentials so we need to make sure the Redis instance has the correct credentials.

Testing

Manual testing and automated functional tests.

Risk

Low.

Regression?

Microsoft Reviewers: Open in CodeFlow

@joperezr
Copy link
Member

Low Risk. Manually tested and added automation. Enabling a brand new feature in 9 to work correctly for RedisInsight. Approved.

@joperezr joperezr merged commit 2fffc41 into release/9.0 Oct 24, 2024
8 checks passed
@joperezr joperezr deleted the backport/pr-6425-to-release/9.0 branch October 24, 2024 22:11
joperezr added a commit to joperezr/aspire that referenced this pull request Nov 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2024
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants