close #2636: added json schemas for Aspire.Hosting.AppHost and Aspire.Hosting.Azure #4912
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "Parameters": { | ||
| "type": "object" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "Azure": { | ||
| "type": "object", | ||
| "properties": { | ||
| "SubscriptionId": { | ||
| "description": "Azure Subscription Id that will be used to host aspire app", | ||
| "type": "string" | ||
| }, | ||
| "ResourceGroup": { | ||
| "description": "Azure Resource Group name where to create resources", | ||
| "type": "string" | ||
| }, | ||
| "ResourceGroupPrefix": { | ||
| "description": "Azure Resource Group prefix used in resource groups names created", | ||
| "type": "string" | ||
| }, | ||
| "AllowResourceGroupCreation": { | ||
| "description": "Flag that shows if it is allowed to create a resource group if not exists", | ||
| "type": "boolean" | ||
| }, | ||
| "Location": { | ||
| "description": "Azure Location that will be used to create resources", | ||
| "type": "string" | ||
| }, | ||
| "CredentialSource": { | ||
| "description": "Shows where to look for Azure credentials", | ||
| "enum": [ | ||
| "AzureCli", | ||
| "AzurePowerShell", | ||
| "VisualStudio", | ||
| "VisualStudioCode", | ||
| "AzureDeveloperCli", | ||
| "InteractiveBrowser", | ||
| "Default" | ||
| ], | ||
| "default": "Default" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,6 @@ | ||||||
| <Project> | ||||||
|
||||||
| <ItemGroup> | ||||||
| <JsonSchemaSegment Include="$(MSBuildThisFileDirectory)..\AspireAzureConfigurationSchema.json" | ||||||
| FilePathPattern="appsettings\..*json" /> | ||||||
|
||||||
| FilePathPattern="appsettings\..*json" /> | |
| FilePathPattern="appsettings\..*json|secrets.json" /> |
There was a problem hiding this comment.
I tried to add it, but it didn't work for me. So I skipped for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <Project> | ||
| <Import Project="..\build\Aspire.Hosting.Azure.targets" /> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <Project> | ||
| <Import Project="..\build\Aspire.Hosting.Azure.targets" /> | ||
| </Project> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should just pack the one file we want, that way we don't accidently start including other .json files we don't intend to put in the nupkg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, fixed it