Skip to content

Rename ASPIREPUBLISHERS001 to sequential ASPIREPIPELINES001-003 diagnostic codes #12416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 28, 2025
Merged

Rename ASPIREPUBLISHERS001 to sequential ASPIREPIPELINES001-003 diagnostic codes #12416

merged 5 commits into from
Oct 28, 2025

Conversation

Copy link
Contributor

Copilot AI commented Oct 27, 2025 •
edited
Loading

Update Experimental diagnostic codes in pipelines area

This PR updates Experimental diagnostic codes according to the issue requirements, using sequential numbering for all pipeline-related experimental APIs.

Changes Completed

  • Update pipeline-related APIs to use ASPIREPIPELINES001 (previously ASPIREPUBLISHERS001)

    • Files in src/Aspire.Hosting/Pipelines/ directory (16 files)
    • Pipeline-related files in src/Aspire.Hosting/Publishing/ (3 files)
    • PublishingCallbackAnnotation (publishing callback)
    • PublishingContext and PublishingExtensions (pipeline activity reporters)
    • PublishingContextUtils in Shared
    • Updated test files and playground files

  • Update deployment state manager APIs to use ASPIREPIPELINES002 (previously ASPIREPUBLISHERS001)

    • IDeploymentStateManager and implementations (4 files)
    • Deploy, ClearCache, Step properties in PublishingOptions
    • Azure provisioning files (6 files)
    • Kubernetes and Orchestrator files (2 files)
    • Updated test files

  • Update container image build APIs to use ASPIREPIPELINES003 (previously ASPIREPUBLISHERS001)

    • IResourceContainerImageBuilder and ContainerBuildOptions
    • ContainerImageFormat, ContainerTargetPlatform, ContainerTargetPlatformExtensions
    • Docker and Podman container runtime implementations (4 files)
    • Container-related files in Azure, Docker, and core projects (4 files)
    • Updated test files

  • Update API file (src/Aspire.Hosting/api/Aspire.Hosting.cs)

  • Build verification completed successfully

  • Code review completed and issues addressed

  • Security check completed (no issues found)

  • Fixed duplicate pragma warnings and ordering issues

Summary

All ASPIREPUBLISHERS001 diagnostic codes have been replaced with sequential diagnostic codes:

  • ASPIREPIPELINES001: For pipeline infrastructure (IPipelineActivityReporter, IReportingStep, CompletionState, PublishingContext, etc.)
  • ASPIREPIPELINES002: For deployment state management (IDeploymentStateManager, Deploy/ClearCache/Step options)
  • ASPIREPIPELINES003: For container image building (IResourceContainerImageBuilder, ContainerBuildOptions, container runtimes)

The sequential numbering provides a consistent naming scheme for all pipeline-related experimental APIs.

Original prompt

This section details on the original issue you should resolve

<issue_title>Fix up Experimental diagnostic codes in pipelines area</issue_title>
<issue_description>- Update any Experimental attributes that are related to pipelines but use ASPIREPUBLISHERS001 to use ASPIREPIPELINES001.

  • Update any public deployment state manager APIs that are publish to use ASPIREDEPLOYMENT001 as a code.
  • Update any APIs that are related to container image builds to use ASPIREIMGBUILD001. </issue_description>

Comments on the Issue (you are @copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Fix experimental diagnostic codes in pipelines area Split ASPIREPUBLISHERS001 into specific diagnostic codes for pipelines, deployment, and image builds Oct 27, 2025
Copilot finished work on behalf of captainsafia October 27, 2025 21:39
Copilot AI requested a review from captainsafia October 27, 2025 21:39
@captainsafia
Copy link
Member

captainsafia commented Oct 27, 2025

@copilot Rename the diagnostic codes to be ASPIREPIPELINES001, ASPIREPIPELINES002, etc.

@captainsafia
Rename diagnostic codes to sequential ASPIREPIPELINES001-003
2a886eb 
Changed ASPIREDEPLOYMENT001 to ASPIREPIPELINES002 and ASPIREIMGBUILD001 to ASPIREPIPELINES003 for consistency with sequential numbering scheme.

Co-authored-by: captainsafia <[email protected]>
Copy link
Contributor Author

Copilot AI commented Oct 27, 2025

@copilot Rename the diagnostic codes to be ASPIREPIPELINES001, ASPIREPIPELINES002, etc.

Done. Changed to sequential numbering: ASPIREPIPELINES001, ASPIREPIPELINES002, and ASPIREPIPELINES003 (commit 2a886eb).

Copilot AI changed the title Split ASPIREPUBLISHERS001 into specific diagnostic codes for pipelines, deployment, and image builds Rename ASPIREPUBLISHERS001 to sequential ASPIREPIPELINES001-003 diagnostic codes Oct 27, 2025
Copilot finished work on behalf of captainsafia October 27, 2025 22:40
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025 •
edited
Loading

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12416

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12416"

This was referenced Oct 27, 2025
Closed
Closed
@captainsafia captainsafia marked this pull request as ready for review October 27, 2025 23:09
Copilot AI review requested due to automatic review settings October 27, 2025 23:09
Copilot AI reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes experimental diagnostic codes from a single ASPIREPUBLISHERS001 identifier into three sequential codes under the ASPIREPIPELINES naming scheme. The split improves granularity by separating pipeline infrastructure (ASPIREPIPELINES001), deployment state management (ASPIREPIPELINES002), and container image building (ASPIREPIPELINES003) into distinct suppressible diagnostics.

Key changes:

  • Renamed ASPIREPUBLISHERS001 to ASPIREPIPELINES001 for pipeline/reporting APIs
  • Introduced ASPIREPIPELINES002 for deployment state management APIs
  • Introduced ASPIREPIPELINES003 for container image building APIs

Reviewed Changes

Copilot reviewed 65 out of 65 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Aspire.Hosting/api/Aspire.Hosting.cs Updated public API surface with new diagnostic codes
src/Aspire.Hosting/Publishing/*.cs Applied new diagnostic codes to publishing infrastructure
src/Aspire.Hosting/Pipelines/*.cs Updated pipeline infrastructure to use ASPIREPIPELINES001
src/Aspire.Hosting.Azure/Provisioning/*.cs Updated Azure provisioning to use ASPIREPIPELINES002
tests/**/*.cs Updated pragma suppressions across all test files
playground/**/*.cs Updated playground examples with new diagnostic codes

playground/pipelines/Pipelines.Library/DistributedApplicationPipelineExtensions.cs Outdated
Comment on lines 1 to 4
#pragma warning disable ASPIREPIPELINES001
#pragma warning disable ASPIRECOMPUTE001
#pragma warning disable ASPIREAZURE001
#pragma warning disable ASPIREPIPELINES001
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate pragma warning suppression for ASPIREPIPELINES001 on lines 1 and 4. Remove the duplicate on line 4 to avoid redundancy.

Copilot uses AI. Check for mistakes.
playground/pipelines/Pipelines.AppHost/AppHost.cs Outdated
Comment on lines 3 to 4
#pragma warning disable ASPIREPIPELINES001

Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate pragma warning suppression for ASPIREPIPELINES001 on lines 1 and 3. Remove the duplicate on line 3 to avoid redundancy.

Suggested change
#pragma warning disable ASPIREPIPELINES001

Copilot uses AI. Check for mistakes.
tests/Aspire.Hosting.Tests/Pipelines/DistributedApplicationPipelineTests.cs Outdated
Comment on lines 5 to 6
#pragma warning disable ASPIREPIPELINES002
#pragma warning disable ASPIREPIPELINES001
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Pragma directives should be ordered consistently. Consider placing ASPIREPIPELINES001 before ASPIREPIPELINES002 to maintain sequential ordering of diagnostic codes.

Suggested change
#pragma warning disable ASPIREPIPELINES002
#pragma warning disable ASPIREPIPELINES001
#pragma warning disable ASPIREPIPELINES001
#pragma warning disable ASPIREPIPELINES002

Copilot uses AI. Check for mistakes.
@captainsafia
Copy link
Member

captainsafia commented Oct 27, 2025

@copilot Address Copilot's feedback 😅

@captainsafia
Fix duplicate pragma warnings and ordering
87e5ca4 
- Remove duplicate ASPIREPIPELINES001 pragma in playground files
- Reorder pragma warnings to sequential order (001, 002) in test file

Co-authored-by: captainsafia <[email protected]>
Copy link
Contributor Author

Copilot AI commented Oct 27, 2025

@copilot Address Copilot's feedback 😅

Fixed! Removed duplicate pragma warnings and reordered them sequentially (commit 87e5ca4).

Copilot finished work on behalf of captainsafia October 27, 2025 23:23
Copilot AI mentioned this pull request Oct 27, 2025
Merged
@captainsafia captainsafia merged commit 861eadf into main Oct 28, 2025
309 of 311 checks passed
@captainsafia captainsafia deleted the copilot/fix-experimental-diagnostic-codes branch October 28, 2025 04:49
@dotnet-policy-service dotnet-policy-service bot added this to the 13.0 milestone Oct 28, 2025
radical pushed a commit that referenced this pull request Oct 29, 2025
@captainsafia @radical
Rename ASPIREPUBLISHERS001 to sequential ASPIREPIPELINES001-003 diagn…
de8a121 
…ostic codes (#12416)

* Initial plan

* Update Experimental diagnostic codes for pipelines, deployment, and container image builds

Co-authored-by: captainsafia <[email protected]>

* Remove duplicate pragma warning directives

Co-authored-by: captainsafia <[email protected]>

* Rename diagnostic codes to sequential ASPIREPIPELINES001-003

Changed ASPIREDEPLOYMENT001 to ASPIREPIPELINES002 and ASPIREIMGBUILD001 to ASPIREPIPELINES003 for consistency with sequential numbering scheme.

Co-authored-by: captainsafia <[email protected]>

* Fix duplicate pragma warnings and ordering

- Remove duplicate ASPIREPIPELINES001 pragma in playground files
- Reorder pragma warnings to sequential order (001, 002) in test file

Co-authored-by: captainsafia <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: captainsafia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mitchdenny mitchdenny mitchdenny approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

Assignees

@captainsafia captainsafia

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

13.0

Development

Successfully merging this pull request may close these issues.

Fix up Experimental diagnostic codes in pipelines area

3 participants

@captainsafia @mitchdenny