Skip to content

Add CTRL-C guidance message to aspire run command output #10203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 11, 2025
Merged

Add CTRL-C guidance message to aspire run command output #10203

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ecd83ae
Initial plan
Copilot Jul 2, 2025
9681785
Add CTRL-C guidance message to aspire run command output
Copilot Jul 2, 2025
81bd67d
Merge branch 'main' into copilot/fix-6fb67a15-0888-4c5f-92fa-da32b350…
mitchdenny Jul 6, 2025
d8ee041
Update CTRL-C message
mitchdenny Jul 6, 2025
e399c96
Fix CTRL-C message formatting and change "app host" to "apphost"
Copilot Jul 7, 2025
0e9ca8b
Move CTRL+C message to appear after endpoints in codespaces
Copilot Jul 7, 2025
c6f09c2
Fix CTRL+C message positioning in codespaces by improving environment…
Copilot Jul 8, 2025
ff4994c
Fixes to implementation.
mitchdenny Jul 10, 2025
338a1ea
Fix formatting (bye bye pink)
mitchdenny Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Aspire.Cli/Commands/RunCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ protected override async Task<int> ExecuteAsync(ParseResult parseResult, Cancell
}
topGrid.AddRow(Text.Empty, Text.Empty);
topGrid.AddRow(new Align(new Markup($"[bold green]{logsLocalizedString}[/]:"), HorizontalAlignment.Right), new Text(logFile.FullName));
topGrid.AddRow(new Text(string.Empty), new Text(string.Empty));
Copy link

Copilot AI Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Use the existing Text.Empty constant instead of new Text(string.Empty) for an empty cell to reduce allocations and improve readability.

Suggested change
topGrid.AddRow(new Text(string.Empty), new Text(string.Empty));
topGrid.AddRow(Text.Empty, Text.Empty);

Copilot uses AI. Check for mistakes.
topGrid.AddRow(new Text(string.Empty), new Markup(RunCommandStrings.PressCtrlCToStopAppHost));
Copy link

Copilot AI Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guidance message is added after the logs row—per the PR description it should appear before the logs. Move these two AddRow calls so the message displays between the dashboard links and the logs.

Suggested change
topGrid.AddRow(new Align(new Markup($"[bold green]{logsLocalizedString}[/]:"), HorizontalAlignment.Right), new Text(logFile.FullName));
topGrid.AddRow(new Text(string.Empty), new Text(string.Empty));
topGrid.AddRow(new Text(string.Empty), new Markup(RunCommandStrings.PressCtrlCToStopAppHost));
topGrid.AddRow(new Text(string.Empty), new Markup(RunCommandStrings.PressCtrlCToStopAppHost));
topGrid.AddRow(new Align(new Markup($"[bold green]{logsLocalizedString}[/]:"), HorizontalAlignment.Right), new Text(logFile.FullName));
topGrid.AddRow(new Text(string.Empty), new Text(string.Empty));

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jul 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Wrap the guidance message’s Markup in an Align with HorizontalAlignment.Right (like the logs row) to keep column alignment consistent.

Suggested change
topGrid.AddRow(new Text(string.Empty), new Markup(RunCommandStrings.PressCtrlCToStopAppHost));
topGrid.AddRow(new Align(new Text(string.Empty), HorizontalAlignment.Right), new Markup(RunCommandStrings.PressCtrlCToStopAppHost));

Copilot uses AI. Check for mistakes.

_ansiConsole.Write(topPadder);

Expand Down
4 changes: 2 additions & 2 deletions src/Aspire.Cli/Resources/RunCommandStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@
<value>Endpoints</value>
</data>
<data name="PressCtrlCToStopAppHost" xml:space="preserve">
<value>Press [bold]Ctrl+C[/] to stop the app host and exit.</value>
<comment>[bold] should not be localized</comment>
<value>Press [bold white on red]CTRL+C[/] to stop the app host and exit.</value>
<comment>[bold white on red] should not be localized</comment>
</data>
<data name="ProjectCouldNotBeRun" xml:space="preserve">
<value>The project could not be run. For more information run with --debug switch.</value>
Expand Down
6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.cs.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.de.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.es.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.fr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.it.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.ja.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.ko.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.pl.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.pt-BR.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.ru.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.tr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.zh-Hans.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Aspire.Cli/Resources/xlf/RunCommandStrings.zh-Hant.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.