RabbitMQ logs ex.Type / ex.StackTrace, etc instead of standard otel exception.type, exception.stacktrace

[adamint]

See here

cc @Erarndt

[eerhardt]

The reason it used the current names (as far as I can remember) is because the RabbitMQ EventSource it listens to names this information "ex".

aspire/src/Components/Aspire.RabbitMQ.Client/RabbitMQEventSourceLogForwarder.cs

Lines 136 to 159 in f2d158b

	Debug.Assert(EventData.PayloadNames[1] == "ex");
	ArgumentOutOfRangeException.ThrowIfGreaterThanOrEqual(index, 5);
	return index switch
	{
	0 => new(EventData.PayloadNames[0], EventData.Payload[0]),
	< 5 => GetExData(EventData, index),
	_ => throw new UnreachableException()
	};
	static KeyValuePair<string, object?> GetExData(EventWrittenEventArgs eventData, int index)
	{
	Debug.Assert(index >= 1 && index <= 4);
	Debug.Assert(eventData.Payload?.Count == 2);
	var exData = eventData.Payload[1] as IDictionary<string, object?>;
	Debug.Assert(exData is not null && exData.Count == 4);
	return index switch
	{
	1 => new("ex.Type", exData["Type"]),
	2 => new("ex.Message", exData["Message"]),
	3 => new("ex.StackTrace", exData["StackTrace"]),
	4 => new("ex.InnerException", exData["InnerException"]),

So it was just using the underlying names the EventSource information was given.

We can turn these into standard OTel names if that is the agreed upon format.

[davidfowl]

Yes please!

[JamesNK]

While we've here, RabbitMQ appears to put all the exception details in the message. Can it just be the exception message?

[eerhardt]

While we've here, RabbitMQ appears to put all the exception details in the message. Can it just be the exception message?

This will need to be fixed in the RabbitMQ.Client library itself. I've opened rabbitmq/rabbitmq-dotnet-client#1493 for it. The latest 6.x version has better exception formatting (it still shows the full exception to string in the Message however). I've opened #2159 to update to the latest.