Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 24, 2025

Implementation Completed ✅

This PR updates both SetupNugetSources.ps1 and SetupNugetSources.sh scripts to add internal feeds for dotnet-eng and dotnet-tools when their public counterparts are present.

Changes Completed:

  • Update SetupNugetSources.ps1 to detect and add dotnet-eng-internal when dotnet-eng is present
  • Update SetupNugetSources.ps1 to detect and add dotnet-tools-internal when dotnet-tools is present
  • Update SetupNugetSources.sh to detect and add dotnet-eng-internal when dotnet-eng is present
  • Update SetupNugetSources.sh to detect and add dotnet-tools-internal when dotnet-tools is present
  • Add test cases for dotnet-eng feed detection and internal feed addition
  • Add test cases for dotnet-tools feed detection and internal feed addition
  • Run existing tests to ensure no regressions (30/30 tests pass)
  • Manually verify the changes work correctly
  • Update documentation in script headers
  • Code review completed with no issues
  • Security summary documented
  • Revert unintended .gitignore changes

Summary:

Both PowerShell and Shell scripts now detect the presence of dotnet-eng and dotnet-tools public feeds and automatically add their corresponding internal feeds:

  • dotnet-engdotnet-eng-internal
  • dotnet-toolsdotnet-tools-internal

The implementation follows the existing pattern used for dotnet version feeds (dotnet5-10). All 30 tests pass including 5 new tests that verify the new functionality.

Testing Results:

  • ✅ All 30 unit tests pass (25 existing + 5 new)
  • ✅ Manual verification with Shell script - feeds added correctly
  • ✅ Manual verification with PowerShell script - feeds added correctly
  • ✅ Verified compatibility with existing dotnet version feeds (dotnet5-10)
  • ✅ Code review completed with no issues

Security Summary:

  • No new security vulnerabilities introduced
  • Changes follow the exact same pattern as existing code for dotnet5-10 feeds
  • Simple string matching and feed URL construction using established patterns
  • All feed URLs use the same secure Azure DevOps endpoint structure

Related Issue:

Context: https://github.com/dotnet/release/issues/1617

This ensures internal package sources are available during builds and dependency restoration for both .NET 10 and .NET 11 channels.

Original prompt

This section details on the original issue you should resolve

<issue_title>Update SetupNuGetSources scripts to ensure internal feeds are added when public feeds are present for .NET 10 and .NET 11</issue_title>
<issue_description>

  • This issue is blocking
  • This issue is causing unreasonable pain

Update both SetupNuGetSources.ps1 and SetupNuGetSources.sh scripts in the Arcade repo to add the internal feeds dotnet-eng-internal and dotnet-tools-internal to NuGet.config if their corresponding public feeds are present. This should be implemented for both .NET 10 arcade and .NET 11 (main) branches to ensure internal package sources are available during builds and dependency restoration.

Context: https://github.com/dotnet/release/issues/1617

Tasks:

  • Detect when dotnet-eng and dotnet-tools public feeds are present in NuGet.config
  • If present, add dotnet-eng-internal and dotnet-tools-internal feeds
  • Cover both .ps1 (PowerShell) and .sh (shell) script versions
  • Apply for .NET 10 and .NET 11 channels

Labels: area-eng-infrastructure, area-release-pipeline
Issue Type: Task</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update SetupNuGetSources scripts for internal feeds Add support for dotnet-eng-internal and dotnet-tools-internal feeds in SetupNuGetSources scripts Oct 24, 2025
Copilot finished work on behalf of mmitche October 24, 2025 14:58
Copilot AI requested a review from mmitche October 24, 2025 14:58
@mmitche mmitche marked this pull request as ready for review October 24, 2025 16:03
Copilot AI requested a review from mmitche October 28, 2025 21:08
Copilot finished work on behalf of mmitche October 28, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants