Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 24, 2025

Summary

This PR implements fine-grained asset category-based publishing for .NET 10 internal channels, mirroring the behavior already used by public .NET 10 channels. This ensures that infrastructure and tooling packages are published to their dedicated internal feeds rather than the general .NET 10 internal feeds.

Problem

Previously, all .NET 10 internal channel packages were published to either dotnet10-internal (shipping) or dotnet10-internal-transport (non-shipping) feeds, regardless of the asset category. This differed from the public channels, which route packages based on their category:

  • Infrastructure packages → dotnet-eng
  • Tooling packages → dotnet-tools
  • Library packages → dotnet-libraries feeds
  • Core/regular packages → version-specific feeds

Solution

Updated DotNet10InternalFeeds to use the same fine-grained targeting approach:

Asset Category Feed (Shipping) Feed (Non-Shipping)
InfrastructurePackage dotnet-eng-internal dotnet-eng-internal
ToolingPackage dotnet-tools-internal dotnet-tools-internal
LibraryPackage dotnet-libraries-internal dotnet-libraries-internal-transport
CorePackage dotnet10-internal dotnet10-internal-transport
Package dotnet10-internal dotnet10-internal-transport

Changes

  1. Added new feed constant:

    • FeedDotNetEngInternal for infrastructure packages
    • Uses existing FeedDotNetToolsInternal for tooling packages (both shipping and non-shipping)
  2. Updated DotNet10InternalFeeds array to route by asset category (14 feed specifications total, up from 4)

Impact

This change affects all .NET 10 internal channels:

  • .NET 10 Internal (5177)
  • .NET 10 Private (8710)
  • .NET 10.0.1xx SDK Internal (5178, 8858)
  • .NET 10.0.2xx SDK Internal (8857, 8861)
  • .NET 10 RC 2 Internal (6500, 6579)

Testing

  • All existing tests pass (180 passed, 1 skipped)
  • Build completes successfully

Fixes: Context from https://github.com/dotnet/release/issues/1617

Original prompt

This section details on the original issue you should resolve

<issue_title>Update internal publishing to use fine-grained publishing targets based on asset category for dotnet 10 internal channels</issue_title>
<issue_description>Update internal publishing so that internal eng and tools assets are pushed to dotnet-eng-internal and dotnet-tools-internal-transport/dotnet-tools, respectively. This should mirror the behavior of public promotion and be implemented for all .NET 10 channels. See PublishingConstants.cs

Context: https://github.com/dotnet/release/issues/1617

  • This issue is blocking
  • This issue is causing unreasonable pain

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update internal publishing for .NET 10 channels Update internal publishing to use fine-grained publishing targets for .NET 10 channels Oct 24, 2025
Copilot AI requested a review from mmitche October 24, 2025 15:04
Copilot finished work on behalf of mmitche October 24, 2025 15:04
@mmitche mmitche marked this pull request as ready for review October 24, 2025 16:01
Copilot AI requested a review from mmitche October 24, 2025 16:11
Copilot finished work on behalf of mmitche October 24, 2025 16:11
Copilot finished work on behalf of mmitche October 24, 2025 16:18
@mmitche mmitche enabled auto-merge (squash) October 28, 2025 21:03
@mmitche mmitche requested a review from pavel-purma October 28, 2025 21:04
@mmitche mmitche disabled auto-merge October 31, 2025 15:20
@mmitche mmitche merged commit d881687 into main Oct 31, 2025
10 checks passed
@mmitche mmitche deleted the copilot/update-internal-publishing-targets-again branch October 31, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update internal publishing to use fine-grained publishing targets based on asset category for dotnet 10 internal channels

3 participants