Skip to content

Conversation

@JoeRobich
Copy link
Member

In DevDiv access to public package registries is not allowed. The NuGet.VerifyMicrosoftPackage is available from the dotnet-public feed so we should use that instead of nuget.org.

@mmitche
Copy link
Member

mmitche commented Sep 24, 2025

Does the nuget.exe download work with the network boundary?

@JoeRobich
Copy link
Member Author

@mmitche mmitche merged commit 81a615d into release/10.0 Sep 25, 2025
10 checks passed
@mmitche mmitche deleted the dev/jorobich/use-dotnet-public-feed branch September 25, 2025 14:46
@mmitche
Copy link
Member

mmitche commented Sep 25, 2025

/backport to main

@github-actions
Copy link
Contributor

@akoeplinger
Copy link
Member

/backport to release/9.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Started backporting to release/9.0: https://github.com/dotnet/arcade/actions/runs/18228867243

@akoeplinger
Copy link
Member

/backport to release/8.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Started backporting to release/8.0: https://github.com/dotnet/arcade/actions/runs/18228872763

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

@akoeplinger backporting to "release/8.0" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Use dotnet-public feed for downloading NuGet.VerifyMicrosoftPackage
Using index info to reconstruct a base tree...
A	eng/common/post-build/nuget-verification.ps1
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): eng/common/post-build/nuget-verification.ps1 deleted in HEAD and modified in Use dotnet-public feed for downloading NuGet.VerifyMicrosoftPackage.  Version Use dotnet-public feed for downloading NuGet.VerifyMicrosoftPackage of eng/common/post-build/nuget-verification.ps1 left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Use dotnet-public feed for downloading NuGet.VerifyMicrosoftPackage
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@akoeplinger
Copy link
Member

looks like 8.0 didn't have that script so we're good there

@JoeRobich
Copy link
Member Author

looks like 8.0 didn't have that script so we're good there

@akoeplinger 8.0 downloads the script and runs it. Seems it was brought into Arcade in 9.0. It might be good to bring it into 8.0 as well with the changed feed.

@akoeplinger
Copy link
Member

ohh interesting, yeah that sounds reasonable

akoeplinger added a commit that referenced this pull request Oct 3, 2025
Extracted from #14809

This is necessary so we can apply the CFS fix from #16154
@akoeplinger
Copy link
Member

opened #16189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants