Skip to content

bump Microsoft.CodeAnalysis to latest #13699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2023
Merged

bump Microsoft.CodeAnalysis to latest #13699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60aac54
bump Microsoft.CodeAnalysis to latest
oleksandr-didyk May 25, 2023
096ce5a
Change CodeAnalysis version to 4.6.0
ViktorHofer May 28, 2023
2f75d4b
baseline Microsoft.CodeAnalysis
oleksandr-didyk May 29, 2023
d5b2def
Update Versions.props
ViktorHofer May 29, 2023
d266454
Merge branch 'main' into bump-code-analysis-to-latest
ViktorHofer May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions eng/SourceBuildPrebuiltBaseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,14 @@
<!-- TODO: Ignore needed until https://github.com/NuGet/Home/issues/11059 is addressed. -->
<UsagePattern IdentityGlob="Nuget.*/*" />

<!-- GenFacades needs to load this in during the build, restricting SBRP usage. Moreover,
latest version cannot be referenced as this dependency sets the minimum version that is
required to be present inbox in the SDK and Roslyn VS. For more information see
https://github.com/dotnet/arcade/pull/13699#discussion_r1205752883.

In the product build a version from previosly-source-build artifacts is utilized thanks
to the corresponding entry in Version.Details.xml -->
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.*/*" />

</IgnorePatterns>
</UsageData>
4 changes: 4 additions & 0 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
<ProductDependencies>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="4.6.0">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>c3cc1d0ceeab1a65da0217e403851a1e8a30086a</Sha>
</Dependency>
<Dependency Name="Microsoft.SymbolUploader.Build.Task" Version="2.0.0-preview.1.21526.15">
<Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-symuploader</Uri>
<Sha>62ceb439e80bf0814d0ffa17f022d4624ea4aa6c</Sha>
Expand Down
4 changes: 2 additions & 2 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
<NuGetProjectModelVersion>6.2.2</NuGetProjectModelVersion>
<NuGetVersioningVersion>6.2.2</NuGetVersioningVersion>
<!-- roslyn -->
<MicrosoftCodeAnalysisCSharpVersion>4.4.0</MicrosoftCodeAnalysisCSharpVersion>
<MicrosoftNetCompilersToolsetVersion>4.5.2-3.23266.1</MicrosoftNetCompilersToolsetVersion>
<MicrosoftCodeAnalysisCSharpVersion>4.6.0</MicrosoftCodeAnalysisCSharpVersion>
<MicrosoftNetCompilersToolsetVersion>4.6.0</MicrosoftNetCompilersToolsetVersion>
<!-- runtime -->
<MicrosoftExtensionsDependencyInjectionAbstractionsVersion>6.0.0</MicrosoftExtensionsDependencyInjectionAbstractionsVersion>
<MicrosoftExtensionsDependencyInjectionVersion>6.0.0</MicrosoftExtensionsDependencyInjectionVersion>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.DotNet.CodeAnalysis/Analyzers/MembersMustExistAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class MembersMustExistAnalyzer : BaseAnalyzer
private HashSet<string> _apisToEnsureExist = new HashSet<string>(StringComparer.OrdinalIgnoreCase);

private static readonly DiagnosticDescriptor s_memberMustExistDiagnostic =
new DiagnosticDescriptor(DiagnosticIds.BCL0001.ToString(), s_title, s_messageFormat, s_analyzerName, DiagnosticSeverity.Error, isEnabledByDefault: true, description: s_description);
new DiagnosticDescriptor(DiagnosticIds.BCL0001.ToString(), s_title, s_messageFormat, s_analyzerName, DiagnosticSeverity.Error, isEnabledByDefault: true, description: s_description, customTags: WellKnownDiagnosticTags.CompilationEnd);

public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get { return ImmutableArray.Create(s_memberMustExistDiagnostic); } }

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.DotNet.CodeAnalysis/Microsoft.DotNet.CodeAnalysis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeBuildOutput>false</IncludeBuildOutput>
<IsPackable>true</IsPackable>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodeAnalysis.ruleset</CodeAnalysisRuleSet>
<SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
<TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);_AddAnalyzerToOutput</TargetsForTfmSpecificContentInPackage>
Expand Down