-
Notifications
You must be signed in to change notification settings - Fork 564
[ci] Remove remaining Classic test jobs. #7924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
98daf20 to
7192d34
Compare
| condition: and(succeeded(), eq('${{ parameters.signClassicPkgContent }}', 'true')) | ||
|
|
||
| - task: MSBuild@1 | ||
| displayName: PKG signing - sign binutils executables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to take a closer look at this, I believe we'll still need to sign macOS specific files that go into our .NET NuGet packages. We likely won't be able to remove all of these steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave them alone if we don't want to tackle this right away. I only removed them because the naming suggested they were for Classic only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a diff that should only remove classic file MacDev cert signing https://gist.github.com/pjcollins/28b1bd5341ffc7a09a16b9d71436e98f. We'll also want to manually queue an official build against this branch to see if anything else breaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied the patch. Looks like the SBOM job is failing on the "main" pipeline:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7554443&view=results
Feel free to commit fix(es) to this branch if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to remove the statusContexts parameter here https://github.com/xamarin/xamarin-android/blob/main/build-tools/automation/azure-pipelines.yaml#L994, though I am not sure if it is optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's fixed now:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7581927&view=results
8ecd953 to
8a9d131
Compare
* main: (94 commits) [ci] Remove remaining Classic test jobs. (dotnet#7924) Add Nightly Tests for Humanizer [readme] Add aka.ms links for d17.5. (dotnet#7935) [tests] Remove `net472` multitargeting (dotnet#7932) [monodroid] Fix `ld` build error on Nightly Builds. (dotnet#7925) Bump to xamarin/Java.Interop/main@0355acf (dotnet#7931) [tests] Use msftconnecttest.com in QuoteInvalidQuoteUrlsShouldWork (dotnet#7919) [ci] Don't set demands for megapipeline (dotnet#7929) [Mono.Android] Bind API-UpsideDownCake Developer Preview 1 (dotnet#7796) Bump to dotnet/installer@d109cba3ff 8.0.100-preview.4.23176.5 (dotnet#7921) [Xamarin.Android.Build.Tasks] Fix Android Version Code for Release builds (dotnet#7795) Bump to dotnet/installer@27d6769dfb 8.0.100-preview.4.23172.16 (dotnet#7910) [Xamarin.Android.Build.Tasks] Fix native code generation when marshal methods are disabled (dotnet#7899) [ci] Optimize 'APK's .NET' test job overhead. (dotnet#7904) [Mono.Android] delay JNINativeWrapper.get_runtime_types() (dotnet#7913) Bump external/Java.Interop from `73ebad2` to `53bfb4a` (dotnet#7914) [build] remove .NET 6 support (dotnet#7900) [profiled-aot] update `dotnet.aotprofile` for .NET 8 (dotnet#7908) [tests] Add backup ssl sites in case of 429 response. (dotnet#7909) $(AndroidPackVersionSuffix)=preview.4; net8 is 34.0.0-preview.4 (dotnet#7912) ...
* main: [ci] Remove remaining Classic test jobs. (dotnet#7924) Add Nightly Tests for Humanizer
Removes the remaining Xamarin.Android Classic test jobs from
mainci.Not all of these have been ported to .NET. Issue #7906 tracks these jobs and whether we should port them or if they are no longer needed.
Additionally, this no longer builds or uploads the Classic
.vsix/.pkginstallers.