[Xamarin.Android.Build.Tasks] _ResolveAssemblies better handle missing assemblies #2622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g assemblies Fixes: dotnet#2548 Fixes: http://work.devdiv.io/753650 In the case of the Android designer, a `SetupDependenciesForDesigner` target is run as a way to "build enough" things for the designer to work. The problem is if a `<ProjectReference/>` hasn't built yet, the `_ResolveAssemblies` target can fail: "HelloForms.Android.csproj" (SetupDependenciesForDesigner target) (1:7) -> (_ResolveAssemblies target) -> Xamarin.Android.Common.targets(1898,2): error : Exception while loading assemblies: System.InvalidOperationException: Failed to load assembly HelloForms\bin\Debug\netstandard2.0\HelloForms.dll Xamarin.Android.Common.targets(1898,2): error : at Xamarin.Android.Tasks.ResolveAssemblies.Execute(DirectoryAssemblyResolver resolver) In this case, I ran: msbuild .\HelloForms\HelloForms.Android\HelloForms.Android.csproj /t:SetupDependenciesForDesigner /p:DesignTimeBuild=true /p:AndroidUseManagedDesignTimeResourceGenerator=false /restore /bl From a fresh checkout of this sample: https://github.com/jonathanpeppers/HelloWorld/ To fix this problem, we can add an `Exists` check in the `Condition` for assemblies passed into the `<ResolveAssemblies/>` MSBuild task. I don't think this will have any negative consequences, since we are already doing a check for `Exists ('$(OutDir)$(TargetFileName)')`. I also setup a new test that emulates what happens with `SetupDependenciesForDesigner`. This should also help us make sure we aren't breaking the designer in this repo. Downstream in monodroid, we should also make sure the designer tests we have there are using a `<ProjectReference/>`.
Member
Author
|
/cc @garuma @alanmcgovern |
dellis1972
approved these changes
Jan 16, 2019
jonpryor
pushed a commit
that referenced
this pull request
Jan 17, 2019
…g assemblies (#2622) Fixes: #2548 Fixes: http://work.devdiv.io/753650 In the case of the Android designer, a `SetupDependenciesForDesigner` target is run as a way to "build enough" things for the designer to work. The problem is if a `<ProjectReference/>` hasn't built yet, the `_ResolveAssemblies` target can fail: "HelloForms.Android.csproj" (SetupDependenciesForDesigner target) (1:7) -> (_ResolveAssemblies target) -> Xamarin.Android.Common.targets(1898,2): error : Exception while loading assemblies: System.InvalidOperationException: Failed to load assembly HelloForms\bin\Debug\netstandard2.0\HelloForms.dll Xamarin.Android.Common.targets(1898,2): error : at Xamarin.Android.Tasks.ResolveAssemblies.Execute(DirectoryAssemblyResolver resolver) In this case, I ran: msbuild .\HelloForms\HelloForms.Android\HelloForms.Android.csproj /t:SetupDependenciesForDesigner /p:DesignTimeBuild=true /p:AndroidUseManagedDesignTimeResourceGenerator=false /restore /bl From a fresh checkout of this sample: https://github.com/jonathanpeppers/HelloWorld/ To fix this problem, we can add an `Exists` check in the `Condition` for assemblies passed into the `<ResolveAssemblies/>` MSBuild task. I don't think this will have any negative consequences, since we are already doing a check for `Exists ('$(OutDir)$(TargetFileName)')`. I also setup a new test that emulates what happens with `SetupDependenciesForDesigner`. This should also help us make sure we aren't breaking the designer in this repo. Downstream in monodroid, we should also make sure the designer tests we have there are using a `<ProjectReference/>`.
garuma
pushed a commit
that referenced
this pull request
Jan 25, 2019
…g assemblies (#2622) Fixes: #2548 Fixes: http://work.devdiv.io/753650 In the case of the Android designer, a `SetupDependenciesForDesigner` target is run as a way to "build enough" things for the designer to work. The problem is if a `<ProjectReference/>` hasn't built yet, the `_ResolveAssemblies` target can fail: "HelloForms.Android.csproj" (SetupDependenciesForDesigner target) (1:7) -> (_ResolveAssemblies target) -> Xamarin.Android.Common.targets(1898,2): error : Exception while loading assemblies: System.InvalidOperationException: Failed to load assembly HelloForms\bin\Debug\netstandard2.0\HelloForms.dll Xamarin.Android.Common.targets(1898,2): error : at Xamarin.Android.Tasks.ResolveAssemblies.Execute(DirectoryAssemblyResolver resolver) In this case, I ran: msbuild .\HelloForms\HelloForms.Android\HelloForms.Android.csproj /t:SetupDependenciesForDesigner /p:DesignTimeBuild=true /p:AndroidUseManagedDesignTimeResourceGenerator=false /restore /bl From a fresh checkout of this sample: https://github.com/jonathanpeppers/HelloWorld/ To fix this problem, we can add an `Exists` check in the `Condition` for assemblies passed into the `<ResolveAssemblies/>` MSBuild task. I don't think this will have any negative consequences, since we are already doing a check for `Exists ('$(OutDir)$(TargetFileName)')`. I also setup a new test that emulates what happens with `SetupDependenciesForDesigner`. This should also help us make sure we aren't breaking the designer in this repo. Downstream in monodroid, we should also make sure the designer tests we have there are using a `<ProjectReference/>`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2548
Fixes: http://work.devdiv.io/753650
In the case of the Android designer, a
SetupDependenciesForDesignertarget is run as a way to "build enough" things for the designer to
work.
The problem is if a
<ProjectReference/>hasn't built yet, the_ResolveAssembliestarget can fail:In this case, I ran:
From a fresh checkout of this sample:
https://github.com/jonathanpeppers/HelloWorld/
To fix this problem, we can add an
Existscheck in theConditionfor assemblies passed into the
<ResolveAssemblies/>MSBuild task. Idon't think this will have any negative consequences, since we are
already doing a check for
Exists ('$(OutDir)$(TargetFileName)').I also setup a new test that emulates what happens with
SetupDependenciesForDesigner. This should also help us make sure wearen't breaking the designer in this repo.
Downstream in monodroid, we should also make sure the designer tests
we have there are using a
<ProjectReference/>.