Skip to content

[Xamarin.Android.Build.Tasks] proguard warning code #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018
Merged

[Xamarin.Android.Build.Tasks] proguard warning code #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Documentation/guides/messages/xa4304.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Compiler Error XA4304

The `Proguard` MSBuild task encountered a proguard configuration file
that was not found on disk. These files are generally declared in your
Xamarin.Android project with a build action of
`ProguardConfiguration`. However, Xamarin.Android also generates
proguard configuration files internally during the build process.

To learn more about `Proguard` and how it relates to Android
development, see the [Android documentation][android] or the [Proguard
website][proguard].

## Resolution

Verify you are not declaring a `ProguardConfiguration` build item that
does not exist.

Consider submitting a [bug][bug] if you are getting this warning under
normal circumstances.

[android]: https://developer.android.com/studio/build/shrink-code
[proguard]: https://www.guardsquare.com/en/products/proguard/manual
[bug]: https://github.com/xamarin/xamarin-android/wiki/Submitting-Bugs,-Feature-Requests,-and-Pull-Requests
22 changes: 1 addition & 21 deletions src/Xamarin.Android.Build.Tasks/Tasks/Proguard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,26 +81,6 @@ protected override string ToolName {

public override bool Execute ()
{
Log.LogDebugMessage ("Proguard");
Log.LogDebugMessage (" AndroidSdkDirectory: {0}", AndroidSdkDirectory);
Log.LogDebugMessage (" JavaPlatformJarPath: {0}", JavaPlatformJarPath);
Log.LogDebugMessage (" ClassesOutputDirectory: {0}", ClassesOutputDirectory);
Log.LogDebugMessage (" AcwMapFile: {0}", AcwMapFile);
Log.LogDebugMessage (" ProguardGeneratedApplicationConfiguration: {0}", ProguardGeneratedApplicationConfiguration);
Log.LogDebugMessage (" ProguardJarOutput: {0}", ProguardJarOutput);
Log.LogDebugTaskItems (" ProguardGeneratedReferenceConfiguration:", ProguardGeneratedReferenceConfiguration);
Log.LogDebugTaskItems (" ProguardGeneratedApplicationConfiguration:", ProguardGeneratedApplicationConfiguration);
Log.LogDebugTaskItems (" ProguardCommonXamarinConfiguration:", ProguardCommonXamarinConfiguration);
Log.LogDebugTaskItems (" ProguardConfigurationFiles:", ProguardConfigurationFiles);
Log.LogDebugTaskItems (" ExternalJavaLibraries:", ExternalJavaLibraries);
Log.LogDebugTaskItems (" DoNotPackageJavaLibraries:", DoNotPackageJavaLibraries);
Log.LogDebugMessage (" UseProguard: {0}", UseProguard);
Log.LogDebugMessage (" EnableLogging: {0}", EnableLogging);
Log.LogDebugMessage (" DumpOutput: {0}", DumpOutput);
Log.LogDebugMessage (" PrintSeedsOutput: {0}", PrintSeedsOutput);
Log.LogDebugMessage (" PrintMappingOutput: {0}", PrintMappingOutput);
Log.LogDebugMessage (" ProguardInputJarFilter: {0}", ProguardInputJarFilter);

EnvironmentVariables = MonoAndroidHelper.GetProguardEnvironmentVaribles (ProguardHome);

return base.Execute ();
Expand Down Expand Up @@ -165,7 +145,7 @@ protected override string GenerateCommandLineCommands ()
if (File.Exists (file))
cmd.AppendSwitchUnquotedIfNotNull ("-include ", $"{enclosingChar}'{file}'{enclosingChar}");
else
Log.LogWarning ("Proguard configuration file '{0}' was not found.", file);
Log.LogCodedWarning ("XA4304", file, 0, "Proguard configuration file '{0}' was not found.", file);
}

libjars.Add (JavaPlatformJarPath);
Expand Down