-
Notifications
You must be signed in to change notification settings - Fork 212
Add torchaudio.models.WaveRNN()
.
#703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Where can you download? |
@GeorgeS2019 PyTorch has original pretrained models and it can be convreted to TorchSharp format as https://github.com/dotnet/TorchSharp/blob/main/docfx/articles/saveload.md. https://download.pytorch.org/torchaudio/models/tacotron2_english_characters_1500_epochs_ljspeech.pth |
@NiklasGustafsson the shared code above is only meant for here without being committed. Do you have a plan on how to commit the above code? Should the code be put in TorchSharp.Example repo? @kaiidams Thank you for making TorchAudio increasingly complete. |
I don't know. @kaiidams has single-handedly made torchaudio real for us, so I will let him take the lead on anything related to audio examples and such. |
Exactly.! |
@NiklasGustafsson Can we have a place to put converted pretrained models for TorchSharpVision and TorchSharpAudio? Python torchvision also downloads pretrained models from the same server as torchaudio (For example MobileNet v2 from https://download.pytorch.org/models/mobilenet_v2-b0353104.pth). I assume that their models have BSD license like their code, but I'm not 100% sure. |
Related issue about pretrained models #588 |
This is an issue we have to address for ML.NET as well as TorchSharp. Adding @luisquintanilla and @ericstj. |
Theses are for me to track the discussion (Just realize *.pth not supported BUT *.pt is for TorchSharp)A list of Torchvision pre-trained models (*.pth) saved using picking I made mistake, this is Wrong, Only .pt
Reference1: MODELS AND PRE-TRAINED WEIGHTS Reference3: load_state_dict_from_url |
We have an internal repo with git LFS for storing large model files that are used by ML.NET and build packages out there. ML.NET consumes those packages during the build for files it needs to redistribute in the final packages. We also use production Azure Storage for files which are not included in the packages and downloaded by ML.NET at runtime. Not sure which path makes the most sense here - let me know.
My understanding is that TorchSharp cannot reuse these models as-is. They need to be ported/converted - is that correct @NiklasGustafsson? |
There are three file formats when discussing TorchSharp
|
Yes, it all depends on what format models were saved in. We do not support pickled models, but we do support TorchScript and the custom weights-only format we invented for PT/TorchSharp data exchange. |
As we don't have
torchaudio.pipelines
to download pretrained models, we need to manually do it.