grad property

[yueyinqiu]

close #1291

[yueyinqiu]

By the way how about the circular reference?

using TorchSharp;

for (; ; )
{
    var t = torch.zeros(1000);
    t.grad = t;
    // t.set_grad(t);
}

PyTorch does not allow that:

However if the trick is played on two tensors, it's ok:

import torch

t = torch.zeros(1000)
g = torch.zeros(1000)
t.grad = g
g.grad = t

I have no idea how to deal with that... Just keep it leaking?

[shaltielshmid]

Why did you remove the detach from dispose scope?
You also removed the MoveToOtherDisposeScope which was listed above in the to function.

[yueyinqiu]

It seems that I have misunderstood something... I have reverted them.

[yueyinqiu]

@shaltielshmid

I have reviewed it again and I'm now more confident about the removal. Could you please check my comment here and the new commit about this?

[yueyinqiu]

Perhaps I shall create a new pull request for this...

[yueyinqiu]

#1299