Skip to content

Raise warning message for insecure protocols #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jun 10, 2020
Merged

Raise warning message for insecure protocols #591

merged 32 commits into from
Jun 10, 2020

Conversation

@DavoudEshtehari
Copy link
Contributor

For protocols, lower than Tls 1.2 raises a warning message by Console.Out in addition to EventSource at Netfx and NetCore.

DavoudEshtehari and others added 26 commits April 24, 2020 12:52
@DavoudEshtehari
Cached the protocol version on Managed SNI
0784b17 
draft
@cheenamalhotra
Initial changes for SNI Merge testing
9266e65
@cheenamalhotra
Add testing support for .NET Standard/Package reference
afa3032
@cheenamalhotra
More improvements + renamed SNI.dll
b4cbbef
@DavoudEshtehari
Receive protocol version
b895c14 
draft
@DavoudEshtehari
Receive protocol version
7f74273 
draft
@DavoudEshtehari
Merge remote-tracking branch 'origin/SSL_TLS_WarningMessage' into SSL…
4be02e0 
…_TLS_WarningMessage
@cheenamalhotra
EOF
c239acc
@cheenamalhotra
Spell
57a3c89
@DavoudEshtehari
Merge remote-tracking branch 'Cheena/temp-sni-merge' into SSL_TLS_War…
cd932fa 
…ningMessage
@DavoudEshtehari
Added project configurations
6acc1b2
@DavoudEshtehari
Merged with Cheena 'temp-sni-merge'
ec0ffe2
@DavoudEshtehari
Added NetCore protocol warning
a997dc6 
draft
@cheenamalhotra
NetFx SNI changes for auto-load
cc7c620
@cheenamalhotra
Capitalize
962b8e4
@DavoudEshtehari
Throw unsecure protocol warning at NetCore
9216b09
@DavoudEshtehari
Throw unsecure protocol warning at NetFx
eefd8ed
@DavoudEshtehari
Merge remote-tracking branch 'Cheena/temp-sni-merge' into SSL_TLS_War…
aeb683e 
…ningMessage

# Conflicts:
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/Interop/SNINativeMethodWrapper.cs
@DavoudEshtehari
Update new SNI approach changes
5ccd763
@DavoudEshtehari
Udate NetFx & add net_invalid_enum message
ab564ce
@DavoudEshtehari
Update NetCore
a708ae3
@DavoudEshtehari
Merge branch 'SSL_TLS_WarningMessage' of github.com:DavoudEshtehari/S…
6345d10 
…qlClient into SSL_TLS_WarningMessage

# Conflicts:
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIHandle.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIMarsHandle.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.Windows.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectManaged.cs
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/Interop/SNINativeMethodWrapper.cs
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
@DavoudEshtehari
Revert "Merge branch 'SSL_TLS_WarningMessage' of github.com:DavoudEsh…
0fd42f3 
…tehari/SqlClient into SSL_TLS_WarningMessage"

This reverts commit 6345d10, reversing
changes made to a708ae3.
@DavoudEshtehari
Improved warning
4c37241
@DavoudEshtehari
Merge remote-tracking branch 'UpStream/master' into SSL_TLS_WarningMe…
bc1de6d 
…ssage

# Conflicts:
#	RunTests.cmd
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
#	src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNIHandle.cs
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/Interop/SNINativeManagedWrapperX64.cs
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/Interop/SNINativeManagedWrapperX86.cs
#	src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/Interop/SNINativeMethodWrapper.cs
#	src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj
#	src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj
#	tools/props/Versions.props
#	tools/specs/Microsoft.Data.SqlClient.nuspec
@DavoudEshtehari
Amended external functions
839c901
cheenamalhotra
cheenamalhotra reviewed Jun 5, 2020
View reviewed changes
karinazhou
karinazhou reviewed Jun 5, 2020
View reviewed changes
@cheenamalhotra cheenamalhotra added this to the 2.0.0 milestone Jun 5, 2020
karinazhou
karinazhou reviewed Jun 9, 2020
View reviewed changes
cheenamalhotra
cheenamalhotra reviewed Jun 9, 2020
View reviewed changes
JRahnama
JRahnama reviewed Jun 9, 2020
View reviewed changes
@cheenamalhotra cheenamalhotra merged commit e601e20 into dotnet:master Jun 10, 2020
This was referenced Jun 10, 2020
Closed
Closed
karinazhou pushed a commit to karinazhou/SqlClient that referenced this pull request Jun 10, 2020
@DavoudEshtehari @karinazhou
Raise warning message for insecure protocols (dotnet#591)
40b2425
@dependabot dependabot bot mentioned this pull request Jul 23, 2025
Open
@edwardneal edwardneal mentioned this pull request Sep 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra left review comments

@David-Engel David-Engel David-Engel approved these changes

+3 more reviewers

@johnnypham johnnypham johnnypham approved these changes

@karinazhou karinazhou karinazhou approved these changes

@JRahnama JRahnama JRahnama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@DavoudEshtehari @cheenamalhotra @johnnypham @David-Engel @karinazhou @JRahnama