perf: Reduce tracing related allocations from TVP write #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uesrt of log enabled in a loop
cheenamalhotra
added
the
NetFx 👈 NetCore
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
JRahnama
approved these changes
May 15, 2020
David-Engel
approved these changes
May 15, 2020
cheenamalhotra
approved these changes
May 15, 2020
cheenamalhotra
added a commit
to cheenamalhotra/SqlClient
that referenced
this pull request
May 15, 2020
Port dotnet#557 to NetFx driver
cheenamalhotra
removed
the
NetFx 👈 NetCore
cheenamalhotra
added a commit
that referenced
this pull request
May 15, 2020
Port #557 to NetFx driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a case where extended metadata trace information is formatted before being passed into an event tracing method which then may not use the string.
I chose not to try and make the tracing code more efficient because it will almost never be used. I've added precheck to see if advanced logging is enabled and passed that as a parameter to the function logging the information because it avoids a per-loop invocation of the event trace flag check.