Remove Diagnostic Source + Configuration Manager from .NET Standard DLL as it's not supported #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
changed the title
Wraith2
reviewed
Apr 22, 2020
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
requested review from
David-Engel,
DavoudEshtehari,
JRahnama and
karinazhou
karinazhou
reviewed
Apr 23, 2020
...qlClient/netcore/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.NetCoreApp.cs
Show resolved
Hide resolved
karinazhou
reviewed
Apr 23, 2020
...soft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDiagnosticListener.NetCoreApp.cs
Outdated
Show resolved
Hide resolved
karinazhou
reviewed
Apr 23, 2020
...oft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDiagnosticListener.NetStandard.cs
Outdated
Show resolved
Hide resolved
karinazhou
approved these changes
Apr 23, 2020
JRahnama
approved these changes
Apr 23, 2020
David-Engel
reviewed
Apr 24, 2020
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs
Outdated
Show resolved
Hide resolved
...soft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs
Show resolved
Hide resolved
David-Engel
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For enhanced experience with .NET Standard 2.0, below changes are needed:
Remove dependency on DiagnosticSource and DiagnosticListener classes as they are not available for .NET Standard 2.0.
Remove dependency on ConfigurationSection as this is also not available in .NET Standard 2.0.
P.S. Tests will be added in a separate PR (post-merge) as that would require rework of existing tests + adding new .NET Standard tests.
Dev NuGet Package for testing the changes:
Microsoft.Data.SqlClient.2.0.0-dev-pr535.nupkg.zip