Skip to content

Fix access token behavior in connection pool #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2020
Merged

Fix access token behavior in connection pool #443

merged 4 commits into from
Feb 25, 2020

Conversation

@cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Feb 24, 2020

@cheenamalhotra cheenamalhotra added this to the 2.0.0-preview2 milestone Feb 24, 2020
@cheenamalhotra cheenamalhotra merged commit 2e3f39e into dotnet:master Feb 25, 2020
cheenamalhotra added a commit to cheenamalhotra/SqlClient that referenced this pull request Mar 3, 2020
@cheenamalhotra
Fix access token behavior in connection pool (dotnet#443)
44b5867 
* Initial test changes

* Fix access token behavior in connection pool

* Compare ordinals for strings

* Access token only
@cheenamalhotra cheenamalhotra mentioned this pull request Oct 21, 2020
Closed
@cheenamalhotra cheenamalhotra mentioned this pull request Jan 25, 2021
Closed
@cheenamalhotra cheenamalhotra mentioned this pull request May 28, 2022
Closed
@dependabot dependabot bot mentioned this pull request Jul 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saurabh500 saurabh500 saurabh500 approved these changes

@David-Engel David-Engel David-Engel approved these changes

@JRahnama JRahnama Awaiting requested review from JRahnama

+2 more reviewers

@karinazhou karinazhou karinazhou approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0-preview2

Development

Successfully merging this pull request may close these issues.

Connection pool doesn't work well with access tokens

5 participants

@cheenamalhotra @saurabh500 @David-Engel @karinazhou @DavoudEshtehari