Skip to content

Conversation

@benrr101
Copy link
Contributor

Description

Disabling test execution in validation stage of official pipeline due to OneBranch removing support for it. Without this, the official build will not launch at all, citing an error like:

image

Testing

A test build with the same change has been launched (although failing due to using official build template on unofficial branch).
https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=127366

@benrr101 benrr101 added this to the 7.0-preview2 milestone Oct 15, 2025
@benrr101 benrr101 requested a review from a team as a code owner October 15, 2025 23:46
@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 23:46
@benrr101 benrr101 added the P0 Use this label to prioritize an issue above everything else, or a critical issue to address ASAP. label Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables test execution in the validation stage of the official signing pipeline due to OneBranch platform removing support for MSBuild tasks in validation stages, which would otherwise prevent the official build from launching.

Key Changes:

  • Commented out the test execution template reference and its parameters in the validation stage

@cheenamalhotra
Copy link
Member

Need not wait for builds to finish to proceed with merge.

@cheenamalhotra cheenamalhotra merged commit fd2aac8 into main Oct 15, 2025
5 of 130 checks passed
@cheenamalhotra cheenamalhotra deleted the dev/russellben/disable-official-test branch October 15, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P0 Use this label to prioritize an issue above everything else, or a critical issue to address ASAP.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants