Attempt to fix Official build - Take #4 #3455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Official pipeline test runs.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix Official build failures by adding a per-build MDS NuGet package version argument to the AKV build steps in the pipeline.
- Updated the MSBuild arguments in the .NET Framework and .NET Core build steps to include the new TestMicrosoftDataSqlClientVersion parameter.
- Ensured that the new argument is added consistently across both pipeline templates.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/common/templates/steps/build-and-run-tests-netfx-step.yml | Added the TestMicrosoftDataSqlClientVersion parameter to the MSBuild arguments for .NET Framework builds. |
| eng/pipelines/common/templates/steps/build-and-run-tests-netcore-step.yml | Added the TestMicrosoftDataSqlClientVersion parameter to the MSBuild arguments for .NET Core builds. |
Comments suppressed due to low confidence (2)
eng/pipelines/common/templates/steps/build-and-run-tests-netfx-step.yml:58
- Please update the related pipeline documentation or parameter configuration schema to include details about the new 'NugetPackageVersion' parameter to ensure clarity for future maintenance.
msbuildArguments: '-p:Configuration=${{parameters.configuration }} -t:BuildAKVNetFx -p:ReferenceType=${{parameters.referenceType }} -p:TestMicrosoftDataSqlClientVersion=${{parameters.NugetPackageVersion }}'
eng/pipelines/common/templates/steps/build-and-run-tests-netcore-step.yml:58
- Please update the pipeline documentation or parameter configuration to document the new 'NugetPackageVersion' parameter to ensure its proper usage in the build process.
msbuildArguments: '-p:Configuration=${{parameters.configuration }} -t:BuildAKVNetCore -p:ReferenceType=${{parameters.referenceType }} -p:TestMicrosoftDataSqlClientVersion=${{parameters.NugetPackageVersion }}'
cheenamalhotra
approved these changes
Jun 27, 2025
mdaigle
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added per-build MDS NuGet package version argument to AKV builds during Official pipeline test runs.