Skip to content

Conversation

@David-Engel
Copy link
Contributor

Targeting a couple of tests that fail intermittently and adding retries.

  • ConnectivityTest
    • Add retries when changing the user mode of the database. I think with parallel jobs, the server may be objecting to simultaneously changing the mode of multiple databases at the same time.
    • Add a new test for connection resiliency. I wrote this for Connection Resiliency does not seem to be working #304 and Fix connection resiliency check #310 but it would still pass, even before the fix, because the async reconnect task still ran with this particular bug and always beat the subsequent query in the context of the unit test. But the test could still catch other code errors which might break connection resiliency, so it will still be good to have.
  • SqlCredentialTest: This test fails intermittently with the server somehow thinking the user is not allowed to change its own password. I suspect this might also be due to other jobs trying to change passwords at the same time and adding a brief wait on failure and retrying may make it pass more consistently.

@cheenamalhotra cheenamalhotra added this to the 2.0.0-preview1 milestone Dec 7, 2019
@David-Engel David-Engel merged commit 2d01403 into dotnet:master Dec 10, 2019
@cheenamalhotra cheenamalhotra added the Area\Tests Issues that are targeted to tests or test projects label Dec 11, 2019
@David-Engel David-Engel deleted the TestImp branch March 4, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Tests Issues that are targeted to tests or test projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants