Fix dependency versions for net8 target #3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
force-pushed
the
dev/cheena/net8
branch
from
fce97bc to
09e1f62
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
David-Engel
approved these changes
Dec 6, 2024
cheenamalhotra
force-pushed
the
dev/cheena/net8
branch
from
875311b to
600e93d
Compare
benrr101
approved these changes
Dec 9, 2024
...ft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/Setup/CertificateUtility.cs
Show resolved
Hide resolved
| @@ -0,0 +1,10 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Didn't @ErikEJ say we didn't need this?
There was a problem hiding this comment.
I can't recall where was the discussion.. we need this for the reason @David-Engel mentioned in the comment linked in PR description.
cheenamalhotra
force-pushed
the
dev/cheena/net8
branch
from
b566c42 to
e2fb60b
Compare
mdaigle
reviewed
Dec 9, 2024
...ft.Data.SqlClient/tests/ManualTests/AlwaysEncrypted/TestFixtures/Setup/CertificateUtility.cs
Show resolved
Hide resolved
mdaigle
approved these changes
Dec 9, 2024
cheenamalhotra
force-pushed
the
dev/cheena/net8
branch
from
2db62a9 to
8373860
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3066 +/- ##
==========================================
- Coverage 72.68% 72.64% -0.04%
==========================================
Files 283 283
Lines 58975 58975
==========================================
- Hits 42864 42842 -22
- Misses 16111 16133 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cheenamalhotra
added a commit
to cheenamalhotra/SqlClient
that referenced
this pull request
Dec 10, 2024
# Conflicts: # src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Fixtures/CertificateFixtureBase.cs # src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Fixtures/ColumnEncryptionCertificateFixture.cs # tools/props/Versions.props
cheenamalhotra
added a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3063 (comment)