Fix | Fix unit test for SPN to include port number with Managed SNI by arellegue · Pull Request #2281 · dotnet/SqlClient

Commits on Dec 18, 2023

Remove ActiveIssue to test pipeline.
arellegue
committed

Commits on Dec 20, 2023

Fix SPN port number Unit Test to use TCP and NP connection strings and Named Instance with or without port number.
arellegue
committed
Try adding retry and delay in creating and using the connection object to fix intermittent issue in the pipeline.
arellegue
committed
Added IsUsingManagedSNI annotation since reflection is using ManagedSNI dll.
arellegue
committed
Add wrapper for all required annotations for the unit test as it is too long.
arellegue
committed
Removed all Sleeps as they are not needed.
arellegue
committed
Add annotation to skip .net framework for SPN port unit test.
arellegue
committed
Put [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] so its the first annotation as the unit test did not skip.
arellegue
committed
Removed SkipOnTargetFramework as it did not stop the unit test from running in pipeline. Added conditional compilation instead.
arellegue
committed

Commits on Dec 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix | Fix unit test for SPN to include port number with Managed SNI#2281

Fix | Fix unit test for SPN to include port number with Managed SNI#2281
DavoudEshtehari merged 21 commits intodotnet:mainfrom
arellegue:FixUnitTestForSPNPortNumber

Commits on Dec 18, 2023

Remove ActiveIssue to test pipeline.

Commits on Dec 20, 2023

Fix SPN port number Unit Test to use TCP and NP connection strings and Named Instance with or without port number.

Try adding retry and delay in creating and using the connection object to fix intermittent issue in the pipeline.

Added IsUsingManagedSNI annotation since reflection is using ManagedSNI dll.

Add wrapper for all required annotations for the unit test as it is too long.

Removed all Sleeps as they are not needed.

Add annotation to skip .net framework for SPN port unit test.

Put [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] so its the first annotation as the unit test did not skip.

Removed SkipOnTargetFramework as it did not stop the unit test from running in pipeline. Added conditional compilation instead.

Commits on Dec 21, 2023

Add validation of InstanceName within the ConditionalThreory annotation.

Removed and sorted using references.

Commits on Dec 22, 2023

Fix ParseDataSource named pipe data source detection to be case insensitive.

Commits on Jan 5, 2024

Applied PR review suggesstions.

Commits on Jan 11, 2024

Moved named pipe protocol port usage assert message to line 138 and used Assert.Fail.

Commits on Jan 19, 2024

Removed all source codes that handle named pipe protocol.

Commits on Jan 24, 2024

Removed unwanted comments as they cause code bloat.

Add SPN pattern validation and use Assert.Equal to compare expected port number agains port number returned in SPN.

Commits on Feb 1, 2024

Merge branch 'main' into FixUnitTestForSPNPortNumber

Added validation for DataSource.

Added assertion if DataSource is valid.

Commits on Feb 23, 2024

Replace If (port > 0) with Assert( port > 0, ...)

Uh oh!

Fix | Fix unit test for SPN to include port number with Managed SNI#2281DavoudEshtehari merged 21 commits intodotnet:maindotnet/SqlClient:mainfrom arellegue:FixUnitTestForSPNPortNumberarellegue/SqlClient:FixUnitTestForSPNPortNumberCopy head branch name to clipboard

Commits

Commits on Dec 18, 2023

Commits on Dec 20, 2023

Commits on Dec 21, 2023

Commits on Dec 22, 2023

Commits on Jan 5, 2024

Commits on Jan 11, 2024

Commits on Jan 19, 2024

Commits on Jan 24, 2024

Commits on Feb 1, 2024

Commits on Feb 23, 2024

Fix | Fix unit test for SPN to include port number with Managed SNI#2281
DavoudEshtehari merged 21 commits intodotnet:mainfrom
arellegue:FixUnitTestForSPNPortNumber