Move to shared SqlClientMetaDataCollectionNames.cs #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd updated references in the netfx csproj
cheenamalhotra
approved these changes
Sep 27, 2021
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlClientMetaDataCollectionNames.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlClientMetaDataCollectionNames.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlClientMetaDataCollectionNames.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
added
the
Code Health 💊
Co-authored-by: Cheena Malhotra <[email protected]>
…relevant Co-authored-by: Cheena Malhotra <[email protected]>
JRahnama
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1261 . Move the netcore version of SqlClientMetaDataCollectionNames.cs to shared src and update references in the netfx csproj. The file is nearly identical between the 2 except for the slashes uses for the include file path. The naming rule violation rule does show up for all the static variables to change them to s_camelCase but I chose not to apply them because they are public and are referenced in 28 places, but they are all from the 2 unit tests
SqlClientMetaDataCollectionNamesTest.csandConnectionSchemaTest.cs. If those should be updated. I can make the changes to fix the coding style violations and update the tests.