Skip to content

Conversation

@ritoban23
Copy link
Contributor

Fix job names consistency between SimpleJobAttribute and --runtimes

Fixes #2840

Problem

When using --runtimes command line arguments, jobs were assigned random names like Job-XXXXXX, while SimpleJobAttribute produced meaningful names like .NET 8.0. This inconsistency made it difficult to identify jobs in benchmark results.

Solution

Added .WithId(runtime.Name) to all job creation paths in ConfigParser.cs:

  • CreateJobForGivenRuntime method
  • CreateAotJob helper method
  • MakeMonoAOTLLVMJob helper method
  • MakeWasmJob helper method

Result

Command-line jobs now use meaningful names that match the runtime (e.g., .NET 8.0, .NET 9.0) instead of random IDs, ensuring consistency with SimpleJobAttribute behavior.

@ritoban23
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ritoban23

@timcassell timcassell added this to the v0.15.5 milestone Oct 13, 2025
@timcassell timcassell merged commit 1c3faa2 into dotnet:master Oct 13, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Different job names when using SimpleJobAttribute vs --runtimes

2 participants