Add Roslyn analyzers to detect incorrect usage of BenchmarkDotNet by silkfire · Pull Request #2837 · dotnet/BenchmarkDotNet

Add Roslyn analyzers to detect incorrect usage of BenchmarkDotNet

silkfire

committed

Unify C# language version

silkfire

committed

Remove Analyzers package projects

silkfire

committed

Revert BenchmarkDotNet.Disassembler changes

silkfire

committed

Reference Analyzers project from Annotations

silkfire

committed

Move Benchmark.Analyzers and Benchmark.Analyzers.Tests to correct directories

silkfire

committed

Remove accidentally added package Microsoft.CodeAnalysis.NetAnalyzers from BenchmarkDotNet.Annotations

silkfire

committed

* Benchmark classes annotated with a [GenericTypeArguments] attribute must be non-abstract and generic

silkfire

committed

* Change diagnostic ID increment ordering

silkfire

committed

When determining whether a class has any benchmark methods, iterate through its ancestors

silkfire

committed

Move "Benchmark class cannot be sealed" to Run analyzer

silkfire

committed

Move "Benchmark class must be public" to Run analyzer

silkfire

committed

Support analyzing overload of BenchmarkRunner.Run that takes a Type parameter created by using a typeof expression

silkfire

committed

Remove requirement that a class must have at least one method annotated with the Benchmark attribute when analyzing GenericTypeArguments attribute rules

silkfire

committed

* Integer attribute values that fit within target type range should not trigger mismatching type diagnostics

silkfire

committed

Use a dummy syntax tree to test whether types are implicitly convertible

silkfire

committed

Move "Generic class must be abstract or annotated with a [GenericTypeArgumentsAttribute]" to Run analyzer and remove abstract modifier requirement

silkfire

committed

Add support to analyze implicit conversion from an array to a Span of said array for [Arguments] attribute values

silkfire

committed

Add support to analyze implicit conversion when using constant values for [Params] and [Arguments] attribute values

silkfire

committed

* Add support to analyze a boolean constant value for the Baseline property on BenchmarkAttribute

silkfire

committed

Add test to OnlyOneMethodCanBeBaselinePerCategory rule verifying that it works correctly with invalid string values

silkfire

committed

Disable warnings for "Missing XML comment for publicly visible type or member" (CS1591)

silkfire

committed

Correct resource strings for OnlyOneMethodCanBeBaselinePerCategory rule

silkfire

committed

Build error fixes

silkfire

committed

Add analyzer projects to main sln.

timcassell

authored and

silkfire

committed

Revert annotations csproj.

timcassell

authored and

silkfire

committed

* Change severity level of "UnnecessarySingleValuePassedToAttribute" rule from warning to information

silkfire

committed

Revert suppressing of BDN1401 in ArgumentsTests.cs

silkfire

committed

Revert suppressing of BDN1401 in FullNameProviderTests.cs, PriorityTests.cs and TypeFilterTests.cs

silkfire

committed

Fix Directory.build.props included in autogenerated projects.

timcassell

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add Roslyn analyzers to detect incorrect usage of BenchmarkDotNet#2837

Add Roslyn analyzers to detect incorrect usage of BenchmarkDotNet#2837
silkfire wants to merge 30 commits intodotnet:masterfrom
silkfire:roslyn-analyzers

Commits on Nov 4, 2025

Add Roslyn analyzers to detect incorrect usage of BenchmarkDotNet

Unify C# language version

Remove Analyzers package projects

Revert BenchmarkDotNet.Disassembler changes

Reference Analyzers project from Annotations

Move Benchmark.Analyzers and Benchmark.Analyzers.Tests to correct directories

Remove accidentally added package Microsoft.CodeAnalysis.NetAnalyzers from BenchmarkDotNet.Annotations

* Benchmark classes annotated with a [GenericTypeArguments] attribute must be non-abstract and generic

* Change diagnostic ID increment ordering

When determining whether a class has any benchmark methods, iterate through its ancestors

Move "Benchmark class cannot be sealed" to Run analyzer

Move "Benchmark class must be public" to Run analyzer

Support analyzing overload of BenchmarkRunner.Run that takes a Type parameter created by using a typeof expression

Remove requirement that a class must have at least one method annotated with the Benchmark attribute when analyzing GenericTypeArguments attribute rules

* Integer attribute values that fit within target type range should not trigger mismatching type diagnostics

Use a dummy syntax tree to test whether types are implicitly convertible

Move "Generic class must be abstract or annotated with a [GenericTypeArgumentsAttribute]" to Run analyzer and remove abstract modifier requirement

Add support to analyze implicit conversion from an array to a Span of said array for [Arguments] attribute values

Add support to analyze implicit conversion when using constant values for [Params] and [Arguments] attribute values

* Add support to analyze a boolean constant value for the Baseline property on BenchmarkAttribute

Add test to OnlyOneMethodCanBeBaselinePerCategory rule verifying that it works correctly with invalid string values

Disable warnings for "Missing XML comment for publicly visible type or member" (CS1591)

Correct resource strings for OnlyOneMethodCanBeBaselinePerCategory rule

Build error fixes

Add analyzer projects to main sln.

Revert annotations csproj.

* Change severity level of "UnnecessarySingleValuePassedToAttribute" rule from warning to information

Revert suppressing of BDN1401 in ArgumentsTests.cs

Revert suppressing of BDN1401 in FullNameProviderTests.cs, PriorityTests.cs and TypeFilterTests.cs

Fix Directory.build.props included in autogenerated projects.

Uh oh!

Add Roslyn analyzers to detect incorrect usage of BenchmarkDotNet#2837silkfire wants to merge 30 commits intodotnet:masterdotnet/BenchmarkDotNet:masterfrom silkfire:roslyn-analyzerssilkfire/BenchmarkDotNet:roslyn-analyzersCopy head branch name to clipboard

Commits

Commits on Nov 4, 2025

Add Roslyn analyzers to detect incorrect usage of BenchmarkDotNet#2837
silkfire wants to merge 30 commits intodotnet:masterfrom
silkfire:roslyn-analyzers