docs: Add docs for breaking changes of disassembler native dependencies #2836
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcassell
reviewed
Oct 10, 2025
|
|
||
| > [!NOTE] | ||
| > By default, BenchmarkDotNet excludes disassembler's native dependencies that aren't used on current target platform. | ||
| > Use the following settings when running the benchmark binary on multiple platforms. |
There was a problem hiding this comment.
Suggested change
| > Use the following settings when running the benchmark binary on multiple platforms. | |
| > Use the following settings when running the benchmark binary on a different platform than it was built on, or multiple platforms. |
timcassell
reviewed
Oct 10, 2025
| > Use the following settings when running the benchmark binary on multiple platforms. | ||
| > | ||
| > ```xml | ||
| > <BenchmarkDotNetTargetPlatform>all</BenchmarkDotNetTargetPlatform> |
There was a problem hiding this comment.
Does it support specifying an exact platform? If not, it would be a good future improvement.
[Edit] Just checked, looks like it does, either by RuntimeIdentifier or BenchmarkDotNetTargetPlatform. It would be good to document it.
|
I would move it to under |
timcassell
requested changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add docs about breaking change that introduced by PR #2737.
After PR #2737 is merged.
It need to explicitly specify following settings to preserve old behaviors.