-
-
Notifications
You must be signed in to change notification settings - Fork 1k
deps: Update package dependencies #2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update package dependencies #2750
Conversation
c0596bb to
10e69fd
Compare
10e69fd to
c57ad52
Compare
adamsitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @filzrev !
| foreach (var version in targetVersions) | ||
| { | ||
| AddJob(baseJob.WithNuGet("Newtonsoft.Json", version) | ||
| .WithCustomBuildConfiguration(version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the WithCustomBuildConfiguration change required to get it to work? If so, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed WithCustomBuildConfiguration setting on latest commit.
When I've tested on v0.14.0 based code previously. wrong DLL version are placed on benchmarks bin directory.
But it seems not needed with latest code (that using ArtifactsPath for benchmark project build)
| </ItemGroup> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' "> | ||
| <PackageReference Include="Microsoft.Win32.Registry" Version="5.0.0" /> | ||
| <!-- Reference System.Numerics.Vectors 4.5.0 (that support net461) as minimum version to avoid MSB3277 warning --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the comment 👍
This PR update package dependencies to latest versions.
How to confirms outdated packages
Run following command.
List of updated packages
FSharp.Core4.6.09.0.300Iced1.17.01.21.0JetBrains.Profiler.SelfApi2.5.112.5.13Microsoft.CodeAnalysis.CSharp4.12.04.14.0Microsoft.Diagnostics.Runtime1.1.1261023.1.512801Microsoft.Diagnostics.Tracing.TraceEvent3.1.83.1.21Microsoft.NETCore.Platforms6.0.07.0.4Microsoft.NETFramework.ReferenceAssemblies1.0.21.0.3Microsoft.NET.Test.Sdk17.7.2[17.13.0]Microsoft.VisualStudio.DiagnosticsHub.BenchmarkDotNetDiagnosers17.13.35606.118.0.36127.1Newtonsoft.Json13.0.1[13.0.1]ScottPlot5.0.545.0.55System.Configuration.ConfigurationManager4.5.09.0.5System.Drawing.Common4.7.29.0.5System.Management6.0.09.0.5System.Memory4.5.54.6.3System.Runtime.CompilerServices.Unsafe6.0.06.1.2System.Threading.Tasks.Extensions4.5.44.6.3System.ValueType4.5.04.6.1Verify.Xunit20.8.230.3.1xunit2.9.22.9.3xunit.runner.visualstudio2.4.1[2.8.2]Note
BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworksproject contains legacy targets (.NET461andnetcoreapp2.0) So it need to usexunit.runner.visualstudiov2.4.1 that compatible these frameworks.Microsoft.NET.Test.Sdk14.0.0 or later depends on NewtonsoftJson13.0.3. So it can't update versionsSystem.Numerics.Vectorsfornetstandard2.0build need to reference4.5.0version (that support net461).Other changes
1.
BenchmarkDotNet.Samples.csprojIntroNativeMemory.csAdd custom benchmark filter (
WindowsOnlyAttribute) to exclude benchmarks that not works on non-Windows OS.(Because
System.Drawing.Commonis not supported .NET 6.0 or later)IntroNuGet.csModify benchmarks to use Newtonsoft.Json
13.0.1as baseline package.And add
WithCustomBuildConfigurationsettings. (It's required when targeting multiple NuGet versions)2.
BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworks.csprojNU1901/NU1902/NU1904.3. Remove
[UsesVerify]attributesThis attribute is removed on latest
xUnit.Verifypackage.Additional manual tests
IntroNuGet/IntroVisualStudioProfilerbenchmark behaviorsBenchmarkDotNet.IntegrationTests.ManualRunningtests behaviors. (Blocked by Some of the tests defined in theBenchmarkDotNet.IntegrationTests.ManualRunningproject failed to run #2751)BenchmarkDotNet.IntegrationTests.ManualRunning.MultipleFrameworkstests behaviors.