Skip to content

Add more rules for API compatibility validation #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 27, 2025
Merged

Add more rules for API compatibility validation #83

merged 7 commits into from
Jan 27, 2025

Conversation

@CptWesley
Copy link
Member

@CptWesley CptWesley commented Jan 26, 2025 •
edited
Loading

Adds the following new rules:

  • Proj0247 Enable strict mode for package baseline validation
  • Proj0248 Enable strict mode for package runtime compatibility validation
  • Proj0249 Enable strict mode for package framework compatibility validation
  • Proj0250 Generate API compatibility suppression file
  • Proj0251 Enable API compatibility attribute checks
  • Proj0252 Enable API compatibility parameter name checks

Implementation: dotnet-project-file-analyzers/dotnet-project-file-analyzers#300

@CptWesley CptWesley self-assigned this Jan 26, 2025
@CptWesley CptWesley mentioned this pull request Jan 26, 2025
Merged
Corniel
Corniel approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@Corniel Corniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However please await @LauraXiulan 's review too.

LauraXiulan
LauraXiulan approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@LauraXiulan LauraXiulan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, just some typos

CptWesley and others added 6 commits January 27, 2025 20:59
@CptWesley @LauraXiulan
Update rules/Proj0247.md
96cc84f 
Co-authored-by: Laura Kramer <[email protected]>
@CptWesley @LauraXiulan
Update rules/Proj0248.md
df5a90a 
Co-authored-by: Laura Kramer <[email protected]>
@CptWesley @LauraXiulan
Update rules/Proj0249.md
f94d125 
Co-authored-by: Laura Kramer <[email protected]>
@CptWesley @LauraXiulan
Update rules/Proj0250.md
80f26b7 
Co-authored-by: Laura Kramer <[email protected]>
@CptWesley @LauraXiulan
Update rules/Proj0251.md
b64c5b8 
Co-authored-by: Laura Kramer <[email protected]>
@CptWesley @LauraXiulan
Update rules/Proj0252.md
628c879 
Co-authored-by: Laura Kramer <[email protected]>
@CptWesley CptWesley merged commit 8563721 into main Jan 27, 2025
@CptWesley CptWesley deleted the compat-api-settings branch January 27, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Corniel Corniel Corniel approved these changes

+1 more reviewer

@LauraXiulan LauraXiulan LauraXiulan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CptWesley CptWesley

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CptWesley @Corniel @LauraXiulan