limit helm delete to eshop

[dariustehrani]

All,
I would like to make a small suggestion to not blindly destroy all the containers within the default namespace.
This is too intrusive if the Kubernetes Cluster is not only serving for eShop purposes.
Therefore I would like to suggest that the cleanup tasks gets modified as followed:

Current

if ($clean) {
    Write-Host "Cleaning previous helm releases..." -ForegroundColor Green
    helm delete --purge $(helm ls -q) 
    Write-Host "Previous releases deleted" -ForegroundColor Green
}

Proposal:

if ($clean) {
    Write-Host "Cleaning previous helm releases..." -ForegroundColor Green
   helm delete --purge $(helm ls -q eshop)
   Write-Host "Previous releases deleted" -ForegroundColor Green
}

This will filter out only those helm deployments containing the word "eshop".

eShopOnContainers/k8s/helm/deploy-all.ps1

Line 47 in 167bb16

helm delete --purge $(helm ls -q)

[mvelosop]

Hi @dariustehrani, thanks for this PR, it seems reasonable.

@eiximenis, could you confirm please?

[dariustehrani]

any progress here?

[mvelosop]

Hi, just pinged @eiximenis for confirmation.

[mvelosop]

@eiximenis just confirmed (on e-mail), so merging now.

Thanks @dariustehrani 😊