Humanize multiline para tag #3234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger.ui (or Redoc, I'm not sure) are displaying '\r\n ' as <pre> tag. PR changes making sure that multi-line <para> text is trimmed and all line breaks within the text are ignored
EvgeniyZ
commented
Jan 25, 2025
test/Swashbuckle.AspNetCore.SwaggerGen.Test/XmlComments/XmlCommentsTextHelperTests.cs
Show resolved
Hide resolved
EvgeniyZ
commented
Jan 25, 2025
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3234 +/- ##
==========================================
+ Coverage 83.58% 83.60% +0.02%
==========================================
Files 76 76
Lines 3161 3165 +4
Branches 536 536
==========================================
+ Hits 2642 2646 +4
Misses 519 519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EvgeniyZ
commented
Jan 25, 2025
src/Swashbuckle.AspNetCore.SwaggerGen/XmlComments/XmlCommentsTextHelper.cs
Show resolved
Hide resolved
src/Swashbuckle.AspNetCore.SwaggerGen/XmlComments/XmlCommentsTextHelper.cs
Outdated
Show resolved
Hide resolved
test/Swashbuckle.AspNetCore.SwaggerGen.Test/XmlComments/XmlCommentsTextHelperTests.cs
Show resolved
Hide resolved
test/Swashbuckle.AspNetCore.IntegrationTests/SwaggerVerifyIntegrationTest.cs
Outdated
Show resolved
Hide resolved
martincostello
approved these changes
Jan 29, 2025
This was referenced Oct 23, 2025
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
shreeinamdar/skills-secure-repository-supply-chain#8
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
timo-wilson24/tute-secure-repository-supply-chain#10
Open
Open
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
Gopikanarra/skills-secure-repository-supply-chain#10
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
Fixes #3009
Details on the issue fix or feature implementation
Swagger.ui (or Redoc, I'm not sure) are displaying
\r\nas<pre>tag.PR changes making sure that text is trimmed and all line breaks are ignored