Skip to content

Conversation

@dohooo
Copy link
Owner

@dohooo dohooo commented Nov 25, 2024

Description

Review

  • I self-reviewed this PR

Testing

  • I added/updated tests
  • I manually tested

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 5f9e49e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-native-reanimated-carousel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-reanimated-carousel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 10:05am

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 25, 2024
@dohooo dohooo changed the title Refactor and fix fix: next item function overscolling with overscrollEnabled is false Nov 25, 2024
@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@4ecf1fa). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/components/CarouselLayout.tsx 89.47% 0 Missing and 4 partials ⚠️
src/store/index.tsx 78.57% 2 Missing and 1 partial ⚠️
src/hooks/useCarouselController.tsx 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage        ?   74.63%           
=======================================
  Files           ?       35           
  Lines           ?      816           
  Branches        ?      235           
=======================================
  Hits            ?      609           
  Misses          ?      143           
  Partials        ?       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dohooo dohooo merged commit 33022e6 into main Nov 25, 2024
6 checks passed
@dohooo dohooo deleted the refactor_and_fix branch November 25, 2024 10:10
@dohooo dohooo mentioned this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants