Skip to content

Conversation

@dohooo
Copy link
Owner

@dohooo dohooo commented Jul 14, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

🦋 Changeset detected

Latest commit: dbf70ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-native-reanimated-carousel Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dohooo dohooo merged commit 49e6d9c into main Jul 14, 2023
@dohooo dohooo deleted the feat/new_rngh_api branch July 14, 2023 07:12
@BrodaNoel
Copy link
Contributor

I'm using this alpha0 version in production, and it's working without problems. ~10k devices.

The only error I see in the console, is the following, but everything is working good.

 ERROR  Warning: Invalid prop `gesture` supplied to `React.Fragment`. React.Fragment can only have `key` and `children` props.
    in IScrollViewGesture
    in RCTView (created by View)
    in View (created by GestureHandlerRootView)
    in GestureHandlerRootView
    in Unknown (created by CarouselComponent)

@BrodaNoel
Copy link
Contributor

The error in the console by be related to this. My render method start with a Fragment element:

  _renderItem = ({ item, index }, PHOTO_HEIGHT) => {
    const currentPhoto = this.props.images[index];

    return (
      <>
        <View style={[styles.image, { height: PHOTO_HEIGHT }]}>
          blablabla
        </View>

        <View>
          blablabla
        </View>
      </>
    );
  };

@dohooo dohooo mentioned this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants