Ensure proxy-manager is not used when native lazy objects are enabled #2884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
fix-classNameResolver
branch
2 times, most recently
from
2d4f5df to
7746f7d
Compare
GromNaN
force-pushed
the
fix-classNameResolver
branch
from
7746f7d to
e67c780
Compare
GromNaN
commented
Oct 31, 2025
| $skippedFieldsFqns = []; | ||
|
|
||
| foreach ($metadata->getIdentifierFieldNames() as $idField) { | ||
| $skippedFieldsFqns[] = $this->propertyFqcn($metadata->getReflectionProperty($idField)); |
There was a problem hiding this comment.
Remove usage of the deprecated ClassMetadata::getReflectionProperty()
GromNaN
commented
Oct 31, 2025
Comment on lines
-464
to
-476
| if ($document instanceof GhostObjectInterface && $document->getProxyInitializer() !== null) { | ||
| // Inject an empty initialiser to not load any object data | ||
| $document->setProxyInitializer(static function ( | ||
| GhostObjectInterface $ghostObject, | ||
| string $method, // we don't care | ||
| array $parameters, // we don't care | ||
| &$initializer, | ||
| array $properties, // we currently do not use this | ||
| ): bool { | ||
| $initializer = null; | ||
|
|
||
| return true; | ||
| }); |
There was a problem hiding this comment.
We need to set the initializer to null, so that the proxy is marked as initialized. Otherwise, updating a value that is already set doesn't initialize the proxy, and the UOW ignore the document when computing changeset.
GromNaN
commented
Oct 31, 2025
| } | ||
|
|
||
| $this->nativeLazyObject = $nativeLazyObject; | ||
| $this->lazyGhostObject = ! $nativeLazyObject || $this->lazyGhostObject; |
There was a problem hiding this comment.
This was setting lazyGhostObject = true when calling setUseNativeLazyObject(false), which is not expected.
GromNaN
commented
Oct 31, 2025
| public ?string $id; | ||
|
|
||
| #[ODM\Field] | ||
| public readonly string $name; |
There was a problem hiding this comment.
Remove the reaonly property that was added in #2840. That makes Doctrine\ODM\MongoDB\Tests\Aggregation\BuilderTest::testAggregationBuilder fail.
GromNaN
commented
Oct 31, 2025
| { | ||
| $configuration = $this->dm->getConfiguration(); | ||
| if (! $configuration->isNativeLazyObjectEnabled() && ! $configuration->isLazyGhostObjectEnabled()) { | ||
| $this->markTestSkipped('Read-only properties are not supported by the legacy Proxy Manager. https://github.com/FriendsOfPHP/proxy-manager-lts/issues/26'); |
There was a problem hiding this comment.
…ction Fix test NestedCollectionsTest with ProxyManager Add a test for read-only properties, not supported by ProxyManager FriendsOfPHP/proxy-manager-lts#26
GromNaN
force-pushed
the
fix-classNameResolver
branch
2 times, most recently
from
51d519a to
e8cbed4
Compare
GromNaN
force-pushed
the
fix-classNameResolver
branch
from
e8cbed4 to
7cc80ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary