Skip to content

Fix the connection via ssh client shellout #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fix the connection via ssh client shellout #2691

merged 1 commit into from
Nov 18, 2020

Conversation

@aiordache
Copy link
Contributor

@aiordache aiordache commented Oct 20, 2020

Avoid overriding the host and port of the http connection pool. It breaks the paramiko connection.

@aiordache aiordache requested a review from chris-crone October 20, 2020 08:08
@aiordache aiordache self-assigned this Oct 20, 2020
@aiordache aiordache changed the title Fix the paramiko ssh connection Alternative ssh connection - bind remote socket locally via ssh Oct 23, 2020
@aiordache aiordache changed the title Alternative ssh connection - bind remote socket locally via ssh Fix the connection via ssh client shellout Nov 9, 2020
@aiordache aiordache force-pushed the fix_ssh_conn branch 2 times, most recently from 35c7743 to c9a8e8b Compare November 9, 2020 16:17
@aiordache aiordache mentioned this pull request Nov 12, 2020
Merged
@aiordache aiordache requested a review from gtardif November 16, 2020 10:56
@aiordache aiordache added this to the 4.4.0 milestone Nov 16, 2020
@aiordache aiordache merged commit d83a2ad into docker:master Nov 18, 2020
This was referenced Dec 16, 2020
Closed
Closed
@shehzaman shehzaman mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gtardif gtardif gtardif approved these changes

@chris-crone chris-crone chris-crone approved these changes

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

Assignees

@aiordache aiordache

Labels

None yet

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@aiordache @gtardif @chris-crone