-
Notifications
You must be signed in to change notification settings - Fork 183
feat: add support for gopass as a credential store #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
540cce2
to
f4090b4
Compare
043a423
to
fc40f5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contrib, please check CI issues.
Also missing build-gopass
make target in build-linux
, build-darwin
and build-windows
stages in the Dockerfile.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 52.08% 52.41% +0.33%
==========================================
Files 13 15 +2
Lines 672 807 +135
==========================================
+ Hits 350 423 +73
- Misses 278 322 +44
- Partials 44 62 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8c1d14a
to
bc197e4
Compare
|
Yep, I'm aware of this and have a WIP solution that should resolve the |
94f7949
to
2439e3a
Compare
I have created a commit which restricts pipeline steps that upload artifacts and/or consume secrets to this upstream repository, allowing me to enable actions in my fork, so that I can iterate on this freely. |
The Windows pipeline now passes: https://github.com/sudoforge/docker-credential-helpers/actions/runs/9899993331/job/27349937852 This tree will now pass all of the pipelines. It has (since the last time it was reviewed) received a few changes:
|
Due to the lack of response from any maintainer, I feel compelled to let people know that they are able to build from my fork and use it, if they desire I will accept no other contributions to the fork at this point in time. |
@sudoforge thank you for chasing this! It's disappointing that it may not get merged in, but I can definitely use your fork. Appreciate the work you've put in here. 🍻 |
…elpers This change adds conditional expressions to restrict the execution of pipeline steps that consume secrets, such as uploading artifacts to remote stores, from being executed unless they are being executed in the context of the upstream `docker/docker-credential-helpers` repository. With this change, downstream, external contributors (users who have forked this repository, and have that fork on GitHub) can enable GitHub Actions in their fork, in order to iterate and validate their changes without waiting on the upstream maintainers. This is extremely helpful to all contributors, because the repository requires maintainer approval in order to execute pipelines, which is burdensome on the maintainers, and due to this restrictive gatekeeping, contributors have an excessively long feedback loop. Signed-off-by: sudoforge <[email protected]>
My fork (also tied to this PR) has been rebased on top of |
c42af5b
to
217186f
Compare
I spent some time today refactoring my tree in order to utilize an API from An area that is still lackluster are tests. In particular, I have a desire to introduce a mocked git repository and gopass cli (wrt configuration, at least), in order to ensure that the tests are fully encapsulated and do not have side effects. This will have to wait until I have more time in the future. |
Updated the pipeline to utilize the most recent release of |
ae84d35
to
907cde6
Compare
if we'd prefer that i do not upgrade the required version of go, i could refactor this tree to use an older revision of the library. also, yes, it added a few indirect dependencies. is there a particular reason we're vendoring deps? |
The most recent push added backwards-compatibility for the |
eec306b
to
f14f223
Compare
c7f4f16
to
94d34c5
Compare
This change adds support for `gopass` as a credential store, utilizing the upstream library. Closes: docker#138 Closes: docker#166 Signed-off-by: sudoforge <[email protected]>
The most recent pushes to my tree were me fighting with the |
1c6bb37
to
9082d90
Compare
This change adds support for
gopass
as a credential store, based onthe
pass
implementation.Closes #138
Closes #166