add sigint and sigterm support for logs when follow flag is used #13132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Lours <[email protected]>
Comment on lines
114
to
116
| eg.Go(func() error { | ||
| return monitor.Start(ctx) | ||
| }) |
There was a problem hiding this comment.
Suggested change
| eg.Go(func() error { | |
| return monitor.Start(ctx) | |
| }) | |
| eg.Go(func() error { | |
| return monitor.Start(ctx) | |
| }) |
Sorry if I jump in, but I got bitten by the recent change done by #13062.
With the fix you propose in this PR I'm afraid we'll have a goroutine leak. I think the monitor.Start will keep running.
Considering only this codebase's use case for the Logs function, the leak won't be a big deal because you always quit the process. However, this will become a problem for other users who use this method (Logs) and do not want to terminate the process.
I think it would be great if we could pass to the monitor.Start/newMonitor something to make it go back the old behaviour (quitting the monitor upon context cancellation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add a channel to monitor SIGINT and SIGTERM and exit immediately the
logscommand when-for--followflag is usedRelated issue
Fix #13118
(not mandatory) A picture of a cute animal, if possible in relation to what you did
