This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[19.03] backport projectquota: protect concurrent map access (ENGCORE-920) #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit 186cd7c) Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit 230a55d) Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit cf104d8) Signed-off-by: Kir Kolyshkin <[email protected]>
Member
|
Looks like this wasn't updated with the latest version: https://jenkins.dockerproject.org/job/Docker-PRs/55136/console Looks like it's cherry-picking moby@b845a74 instead of moby@1ac0a66 |
Protect access to q.quotas map, and lock around changing nextProjectID. Techinically, the lock in findNextProjectID() is not needed as it is only called during initialization, but one can never be too careful. Fixes: 52897d1 ("projectquota: utility class for project quota controls") Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 1ac0a66) Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
19.03-quota-map
branch
from
51f71a8 to
b0f01be
Compare
Author
|
fixed to cherry-pick the latest version |
Author
|
restarted CI |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of
to address
Clean cherry-pick, no issues (moby#39327 is required solely for a clean cherry-pick)