feat(getWeekdays): format and week start override #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Sek
force-pushed
the
feat/weekdays-format
branch
from
bae1f6d to
3c48b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for adapters after restoring
week-formatprop for Vuetify v3 (vuetify#21290).The main goal is to keep it short and contain changes within
getWeekdays- i.e. avoid extendingstartOfWeekwithfirstWeekDayand reusing it ingetWeekdays. It may be a good idea for a follow-up PR.Note: libraries have their own codes and formats and their "narrow" usually contains 2 letters (unlike 1 letter when using
Intl). It is a bit inconsistent (across libraries), but does not really matter a lot and users that really want single letter can always extend adapter class.