-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
[enc] Expose the categories container to C. #11794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves experimental category-related API functions from hidden/internal status to the public C API header, making them officially available as of version 3.2.
Key changes:
- Moved
CategoriesHandletypedef from implementation file to public header - Relocated comprehensive documentation for
XGDMatrixGetCategories,XGDMatrixGetCategoriesExportToArrow, andXGBCategoriesFreefrom implementation to header - Added public declarations for
XGBoosterGetCategoriesandXGBoosterGetCategoriesExportToArrowwith proper documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/c_api/c_api.cc |
Removed documentation comments for category functions that were moved to the public header, cleaned up internal comments |
include/xgboost/c_api.h |
Added CategoriesHandle typedef, comprehensive documentation for all category-related functions with @since 3.2 tags and experimental API notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Can you give me some more context on this PR? I thought the Booster object already supported exporting the categories container as Arrow arrays? How does this PR change things? |
I hid the C functions in the last release in case of unexpected issues. It took me a while to figure out all the states, like whether one needs to re-code data during training continuation, and when input is a DMatrix. This PR exposes these functions to the C header, but they are still marked as experimental. |
No description provided.